Feature #15789: Give requested scrubs a higher priority - Ceph - Ceph

Actions

Copy link

Feature #15789

closed

Give requested scrubs a higher priority

Added by Samuel Just almost 8 years ago. Updated almost 7 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

David Zafman

Category:

Target version:

% Done:

Source:

other

Tags:

Backport:

kraken, jewel

Reviewed:

Affected Versions:

Pull request ID:

Description

It seems like requested scrubs will wait behind scheduled scrubs, that's not great. Since requested scrubs are already inserted into sched_scrub_pg with an immediate deadline they will be the next to start. Since we can't currently interrupt a scrub which is already in progress there is nothing more to do there. Later in the process we schedule actions with the same priority as regular scrubs. Increasing the priority should be helpful.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Wanlong Gao almost 8 years ago

Samuel Just wrote:

It seems like requested scrubs will wait behind scheduled scrubs, that's not great.

Samuel, do you mean requested replica scrub map? I find that the priority of requested replica scrub map op is PRIO_DEFAULT(127), it is higher than default scrub priority(5). So the requested scrub map will be processed first. But what do you mean? would you explain more? thank you. ;)

Actions

Copy link

Updated by Wanlong Gao over 7 years ago

Wanlong Gao wrote:

Samuel Just wrote:

It seems like requested scrubs will wait behind scheduled scrubs, that's not great.

Samuel, do you mean requested replica scrub map? I find that the priority of requested replica scrub map op is PRIO_DEFAULT(127), it is higher than default scrub priority(5). So the requested scrub map will be processed first. But what do you mean? would you explain more? thank you. ;)

Ah, sorry, I understand the requested scrubs means "must_scrub".

Actions

Copy link