Backport #15703
closedhammer: rados bench sometimes numbers not separated by blank
Updated by Vikhyat Umrao almost 8 years ago
Hammer Source File : src/common/obj_bencher.cc
if (i % 20 == 0) { if (i > 0) cur_time.localtime(cout) << "min lat: " << data.min_latency << " max lat: " << data.max_latency << " avg lat: " << data.avg_latency << std::endl; //I'm naughty and don't reset the fill bencher->out(cout, cur_time) << setfill(' ') << setw(5) << "sec" << setw(8) << "Cur ops" << setw(10) << "started" << setw(10) << "finished" << setw(10) << "avg MB/s" << setw(10) << "cur MB/s" << setw(10) << "last lat" << setw(10) << "avg lat" << std::endl; }
last lat and avg lat here has setw(10) : which is causing the issue.
But in Jewel it was changed to :
bencher->out(cout, cur_time) << setfill(' ') << setw(5) << "sec" << setw(8) << "Cur ops" << setw(10) << "started" << setw(10) << "finished" << setw(10) << "avg MB/s" << setw(10) << "cur MB/s" << setw(12) << "last lat(s)" << setw(12) << "avg lat(s)" << std::endl; }
last lat and *avg lat * is changed to setw(12) : I hope this will solve the issue.
<< setw(12) << "last lat(s)"
<< setw(12) << "avg lat(s)" << std::endl;
Updated by Vikhyat Umrao almost 8 years ago
Verified in Jewel , as expected with code change, it works perfectly fine.
Updated by Nathan Cutler almost 8 years ago
So this is a request to backport https://github.com/ceph/ceph/commit/669b9329 ?
Updated by Nathan Cutler almost 8 years ago
- Related to Feature #12248: Add units to rados bench output added
Updated by Vikhyat Umrao almost 8 years ago
Nathan Cutler wrote:
So this is a request to backport https://github.com/ceph/ceph/commit/669b9329 ?
Thanks Nathan for looking into this one. Yes this is the one.
Updated by Nathan Cutler almost 8 years ago
- Related to deleted (Feature #12248: Add units to rados bench output)
Updated by Nathan Cutler almost 8 years ago
- Copied from Feature #12248: Add units to rados bench output added
Updated by Nathan Cutler almost 8 years ago
- Description updated (diff)
Original description¶
rados bench sometimes numbers not separated by blank
`rados bench` output is not readable, as numbers sometimes are not separated by a blank.
Expected behavior: Numbers should be separated by a blank.
Actual output:
2016-04-27 17:40:30.470978min lat: 0.00161851 max lat: 4.61329 avg lat: 0.0769791 sec Cur ops started finished avg MB/s cur MB/s last lat avg lat 1060 256 3524928 3524672 25.9746 25.3594 0.0149067 0.0769791 1061 256 3527461 3527205 25.9688 19.7891 0.0144534 0.0769785 1062 256 3530718 3530462 25.9683 25.44530.00639977 0.0769856 ---> here numbers are not separated
Version-Release number of selected component (if applicable):
Red Hat Ceph Storage 1.3.2
ceph-0.94.5-9.el7cp
How reproducible:
Always
Updated by Brad Hubbard almost 8 years ago
- Copied to Bug #15756: hammer: rados bench sometimes numbers not separated by blank added
Updated by Brad Hubbard almost 8 years ago
- Copied to deleted (Bug #15756: hammer: rados bench sometimes numbers not separated by blank)
Updated by Brad Hubbard almost 8 years ago
Isn't this just a duplicate of http://tracker.ceph.com/issues/12248 ?
Can we close it to avoid (more) confusion please?
Updated by Nathan Cutler almost 8 years ago
- Tracker changed from Bug to Backport
- Subject changed from rados bench sometimes numbers not separated by blank to hammer: add units to rados bench output
Updated by Nathan Cutler almost 8 years ago
@Brad No, this is not a duplicate. It's a backport tracker issue. We track backports separately from the original issues.
Updated by Nathan Cutler almost 8 years ago
- Copied from deleted (Feature #12248: Add units to rados bench output)
Updated by Nathan Cutler almost 8 years ago
- Is duplicate of Backport #15717: hammer: Add units to rados bench output added
Updated by Nathan Cutler almost 8 years ago
- Status changed from New to Duplicate
Updated by Nathan Cutler almost 8 years ago
@Brad My apologies! You were right.
Updated by Nathan Cutler almost 8 years ago
- Subject changed from hammer: add units to rados bench output to hammer: rados bench sometimes numbers not separated by blank