Project

General

Profile

Bug #15585

jewel: debian package: init.d script bug

Added by alexandre derumier almost 8 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Hi,

since this commit
https://github.com/ceph/ceph/commit/65963739cd6815b8008282c8f64cd64365662e60

if [ -n $CEPH_BIN ] && [ -n $CEPH_ROOT ] && [ -n $CEPH_BUILD_DIR ]; then
#need second look at all variables, especially ETCDIR
BINDIR=$CEPH_BIN
SBINDIR=$CEPH_ROOT/src
ETCDIR=$CEPH_BUILD_DIR
LIBEXECDIR=$CEPH_ROOT/src
SYSTEMD_RUN=""
ASSUME_DEV=1
fi

debian init.d script is not working anymore,
variables need to be double quotes, or the test is always true when variables are undefined

- if [ -n $CEPH_BIN ] && [ -n $CEPH_ROOT ] && [ -n $CEPH_BUILD_DIR ]; then
+if [ -n "$CEPH_BIN" ] && [ -n "$CEPH_ROOT" ] && [ -n "$CEPH_BUILD_DIR" ]; then

History

#1 Updated by Bart van Bragt almost 8 years ago

Confirmed with Jewel from the Ceph repository on Debian Jessie.

The /etc/init.d/ceph script doesn't do a thing in it's current state.

#2 Updated by Greg Farnum almost 7 years ago

  • Status changed from New to Resolved

Script in master looks good now; presume it got backported as necessary.

Also available in: Atom PDF