Project

General

Profile

Backport #15283

hammer: RGW shouldn't send Content-Type nor Content-Length for 304 responses

Added by Nathan Cutler almost 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Target version:
Release:
hammer
Crash signature (v1):
Crash signature (v2):


Related issues

Related to rgw - Backport #16382: hammer: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign) Resolved
Copied from rgw - Bug #14005: RGW shouldn't send Content-Type nor Content-Length for 304 responses Resolved 12/07/2015

History

#1 Updated by Nathan Cutler almost 7 years ago

  • Copied from Bug #14005: RGW shouldn't send Content-Type nor Content-Length for 304 responses added

#2 Updated by Wei-Chung Cheng almost 7 years ago

  • Assignee set to Wei-Chung Cheng

#3 Updated by Wei-Chung Cheng almost 7 years ago

  • Description updated (diff)
  • Status changed from New to In Progress

#4 Updated by Sylvain Munaut almost 7 years ago

The current pull request for backport :

https://github.com/ceph/ceph/pull/8379/commits/e53751d0e52f6fb611d9bd81fe2115cd7ce533b3

Is definitely not good. err will be equal to -ERR_NOT_MODIFIED (note the minus sign).

Not sure if the same comment applies to the original (non-backport) patch. I only use hammer ATM.

#5 Updated by Orit Wasserman over 6 years ago

it is also wrong in master, do you want to send a fix?

#6 Updated by Nathan Cutler over 6 years ago

Orit Wasserman wrote:

it is also wrong in master, do you want to send a fix?

Opened #16327 for this bug, master PR is https://github.com/ceph/ceph/pull/9725

Wei-Chung Cheng, when the master PR is merged, could you cherry-pick fc38346 into this backport PR?

#7 Updated by Nathan Cutler over 6 years ago

  • Related to Bug #16327: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign) added

#9 Updated by Nathan Cutler over 6 years ago

  • Related to deleted (Bug #16327: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign))

#10 Updated by Nathan Cutler over 6 years ago

  • Related to Backport #16382: hammer: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign) added

#11 Updated by Nathan Cutler over 6 years ago

  • Status changed from In Progress to Resolved
  • Target version set to v0.94.8

Also available in: Atom PDF