https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2016-03-10T21:31:30ZCeph CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=672662016-03-10T21:31:30ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Project</strong> changed from <i>Ceph</i> to <i>CephFS</i></li></ul> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=672892016-03-10T23:55:48ZGreg Farnumgfarnum@redhat.com
<ul></ul><p>Can you describe in a little more detail how you were creating and deleting these files? You talk about them being 10s of GB — were you writing out data at a very large offset to force them to that size? Actually writing out that much data?</p>
<p>Can you dump the cache on your MDS (it's an admin socket command) and upload it with ceph-post-file? And also dump the perfcounters and share them?</p>
<p>Stuff should be automatically deleted, but neither of your descriptions of time (<10 seconds, nor multiple days) really make sense for files of this size. :/ We did add a "StrayManager" in Infernalis that prevents the MDS from spewing out an infinite number of delete ops at the OSDs which could be going wrong, but it hasn't had any failure reports so far.</p> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=672932016-03-11T02:25:50ZZheng Yanukernel@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>12</i></li></ul><p>we don't handle 'stripe_count > 1' properly when purging stray.</p>
<pre>
if (in->is_file()) {
uint64_t period = (uint64_t)in->inode.layout.fl_object_size *
(uint64_t)in->inode.layout.fl_stripe_count;
uint64_t to = in->inode.get_max_size();
to = MAX(in->inode.size, to);
// when truncating a file, the filer does not delete stripe objects that are
// truncated to zero. so we need to purge stripe objects up to the max size
// the file has ever been.
to = MAX(in->inode.max_size_ever, to);
if (to && period) {
uint64_t num = (to + period - 1) / period;
^^^^
dout(10) << __func__ << " 0~" << to << " objects 0~" << num
<< " snapc " << snapc << " on " << *in << dendl;
filer.purge_range(in->inode.ino, &in->inode.layout, *snapc,
0, num, ceph::real_clock::now(g_ceph_context), 0,
gather.new_sub());
}
}
</pre> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=672942016-03-11T03:03:39ZGreg Farnumgfarnum@redhat.com
<ul><li><strong>Assignee</strong> set to <i>Zheng Yan</i></li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li></ul><p>Well spotted.</p> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=672952016-03-11T03:09:10ZLoïc Dacharyloic@dachary.org
<ul><li><strong>Subject</strong> changed from <i>Infernalis: deleting striped file in cephfs doesn't free up file's space</i> to <i>deleting striped file in cephfs doesn't free up file's space</i></li></ul> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=673052016-03-11T03:38:48ZZheng Yanukernel@gmail.com
<ul><li><strong>Status</strong> changed from <i>12</i> to <i>Fix Under Review</i></li></ul><p><a class="external" href="https://github.com/ceph/ceph/pull/8040">https://github.com/ceph/ceph/pull/8040</a><br /><a class="external" href="https://github.com/ceph/ceph/pull/8041">https://github.com/ceph/ceph/pull/8041</a><br /><a class="external" href="https://github.com/ceph/ceph/pull/8042">https://github.com/ceph/ceph/pull/8042</a></p> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=673192016-03-11T05:14:52ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Backport</strong> set to <i>hammer,infernalis</i></li></ul> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=673202016-03-11T05:16:04ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-9 status-3 priority-5 priority-high3 closed" href="/issues/15056">Backport #15056</a>: hammer: deleting striped file in cephfs doesn't free up file's space</i> added</li></ul> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=673222016-03-11T05:16:53ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-9 status-6 priority-5 priority-high3 closed" href="/issues/15057">Backport #15057</a>: infernalis: deleting striped file in cephfs doesn't free up file's space</i> added</li></ul> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=675702016-03-15T19:28:14ZGreg Farnumgfarnum@redhat.com
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Pending Backport</i></li></ul><p>It's been merged.</p> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=692122016-04-14T21:20:08ZGreg Farnumgfarnum@redhat.com
<ul><li><strong>Priority</strong> changed from <i>High</i> to <i>Normal</i></li></ul><p>Just waiting on backports, FS team doesn't need to worry about those.</p> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=709132016-05-17T14:03:31ZFlorent B
<ul></ul><p>Is it fixed in v10.2.1 ?</p> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=709502016-05-17T20:55:13ZJohn Sprayjcspray@gmail.com
<ul></ul><p>Florent: yes, you can check that kind of thing yourself with a git clone and something like:<br /><pre>
git log --grep "mds: fix stray purging in 'stripe_count > 1' case" v10.2.1
</pre></p> CephFS - Bug #15050: deleting striped file in cephfs doesn't free up file's spacehttps://tracker.ceph.com/issues/15050?journal_id=761222016-08-08T08:33:05ZLoïc Dacharyloic@dachary.org
<ul><li><strong>Status</strong> changed from <i>Pending Backport</i> to <i>Resolved</i></li></ul>