Project

General

Profile

Bug #15042

btrfs buildrequire added to fix make check does not get installed by install-deps.sh

Added by Nathan Cutler almost 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/pull/7742 fixed a make check failure by adding a buildtime dependency:

%if %{with tests}
BuildRequires: btrfsprogs
%endif

However, on RH/Fedora this gets ignored by install-deps.sh because yum-builddeps has no option to define %{with_tests} - the conditional does not trigger.

Since the interest of having all make check dependencies satisfied trumps the interest of keeping build environments small, the fix in this case is to drop the conditional.

Associated revisions

Revision 2294c73d (diff)
Added by Erwan Velu almost 7 years ago

Packaging: Removing conditional BuildRequires for btrfs-progs

By pull request 7742, the btrfs-progs package was considered as a BuildRequires
only when --with tests was engaged like :

if %{with tests}
BuildRequires: btrfsprogs
%endif

That's perfectly valid for a spec file.

The issue we have is the following :
- yum-builddep called by install-deps.sh is used to prepare the build env by
installing the needed BuildRequires.
- %{with test} is defined by using a %bcond_with
- yum-builddep doesn't consider %{with test} as valid
- yum-builddep doesn't install the btrfs package

As per discussions with the yum team, there is no way to engage conditional flags with
yum-builddep.

So this patch, as per discussions with Nathan Cutler & Loic Dachary, is removing
the condition arond the BuildRequires.

Note that all BuildRequires defined with a %bcond_with would be affected by this
issue. The current specfile only have %bcond_without conditional BuildRequires
which is fine.

Fixes: #15042
Signed-off-by: Erwan Velu <>

History

#1 Updated by Nathan Cutler almost 7 years ago

  • Status changed from New to Fix Under Review

master PR: https://github.com/ceph/ceph/pull/8016

Deeper analysis in the commit message there.

#2 Updated by Sage Weil over 6 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF