Project

General

Profile

Feature #14642

Validate layouts everywhere we load them

Added by Greg Farnum over 3 years ago. Updated about 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Administration/Usability
Target version:
-
Start date:
02/04/2016
Due date:
% Done:

0%

Source:
Community (user)
Tags:
new-dev
Backport:
Reviewed:
Affected Versions:
Component(FS):
Client, Common/Protocol, MDS
Labels (FS):
Pull request ID:

Description

See _calculate_ops_required, wherein we divide by their product without checking it's non-zero.


Related issues

Related to fs - Bug #14641: don't let users specify 0 on stripe count or object size Duplicate 02/04/2016

History

#1 Updated by Greg Farnum over 3 years ago

John, I think maybe you said in the user thread that we seem to guard against this on inputs, right? So we've no idea how the values actually got set to zero.

#2 Updated by John Spray over 3 years ago

Yes, and in testing I also found other places in the MDS that get upset with zeros, so the ticket probably either needs to be a broader "validate layouts everywhere we load them" or just get closed.

#3 Updated by Greg Farnum over 3 years ago

  • Tracker changed from Bug to Feature
  • Subject changed from StrayManager: don't crash on object size or stripe counts of 0 to Validate layouts everywhere we load them
  • Tags set to new-dev

Okay, let's put this in as a feature.

#4 Updated by Greg Farnum over 3 years ago

  • Priority changed from High to Normal

#5 Updated by Greg Farnum over 3 years ago

  • Related to Bug #14641: don't let users specify 0 on stripe count or object size added

#6 Updated by Greg Farnum about 3 years ago

  • Category changed from 47 to Administration/Usability
  • Component(FS) Client, Common/Protocol, MDS added

Also available in: Atom PDF