Project

General

Profile

Actions
Copy link

Bug #14558

closed

journal AIO write error message is confusing

Added by Loïc Dachary about 8 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Error handling in FileJournal incorrectly assumes that the content of res always is the size written. If negative, it may be -1 or an errno and should be displayed accordingly.

The change that displayed sizes https://github.com/ceph/ceph/commit/7827e0035e3350ad2d9230f27a1629545f53af5c should be amended.

https://github.com/ceph/ceph/blob/infernalis/src/os/FileJournal.cc#L1513

Related issues 1 (0 open — 1 closed)

Related to Ceph - Bug #9570: osd crash in FileJournal::WriteFinisher::entry() aioRejectedLoïc Dachary09/22/2014

Actions
Actions
Copy link
 #1

Updated by Loïc Dachary about 8 years ago

  • Related to Bug #9570: osd crash in FileJournal::WriteFinisher::entry() aio added
Actions
Copy link
 #2

Updated by Loïc Dachary about 8 years ago

  • Subject changed from journal does not handle error conditions properly to journal AIO write error message is confusing
Actions
Copy link
 #3

Updated by Loïc Dachary about 8 years ago

  • Assignee deleted (Loïc Dachary)
Actions
Copy link
 #4

Updated by Josh Durgin almost 7 years ago

  • Status changed from 12 to Resolved

current code handles this

Actions
Copy link

Also available in: Atom PDF