Project

General

Profile

Bug #14535

rbd CLI does not validate pool and snapshot name optionals

Added by Jason Dillaman about 8 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The "--pool", "--snap", etc optionals are not validated to ensure they don't contain "/" nor "@".

History

#1 Updated by Gaurav Garg over 7 years ago

This bug is not reproducible with jewel."--pool" and "--snap" optionals are not validating to ensure they don't contain "/" or "@".

#2 Updated by Jason Dillaman over 7 years ago

@Gaurav: the issue is that the "--pool" and "--snap" arguments are not validated but they should be for ops that create images and snapshots (e.g. I shouldn't be able to run "rbd snap create --snap "no@in_snap" image").

#3 Updated by Gaurav Garg over 7 years ago

Jason Dillaman wrote:

@Gaurav: the issue is that the "--pool" and "--snap" arguments are not validated but they should be for ops that create images and snapshots (e.g. I shouldn't be able to run "rbd snap create --snap "no@in_snap" image").

Yeah, right. its reproducible with --snap option. i didn't used --snap option while creating snap (i used rbd snap create {pool-name}/{image-name}@{snap-name}). Its a valid issue.

#4 Updated by Gaurav Garg over 7 years ago

  • Assignee set to Gaurav Garg

#5 Updated by Gaurav Garg about 7 years ago

  • Status changed from New to Fix Under Review

#6 Updated by Jason Dillaman almost 7 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF