Project

General

Profile

Bug #14476

rbd: TaskFinisher::cancel should remove event from SafeTimer

Added by Douglas Fuller over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
hammer, infernalis
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

TaskFinisher needs to call SafeTimer::cancel_event, otherwise canceled events fire anyway.


Related issues

Copied to rbd - Backport #14552: infernalis: rbd: TaskFinisher::cancel should remove event from SafeTimer Resolved
Copied to rbd - Backport #14553: hammer: rbd: TaskFinisher::cancel should remove event from SafeTimer Resolved

Associated revisions

Revision 2aa0f318 (diff)
Added by Douglas Fuller over 5 years ago

rbd: remove canceled tasks from timer thread

When canceling scheduled tasks using the timer thread, TaskFinisher::cancel
does not call SafeTimer::cancel_event, so events fire anyway. Add this call.

Fixes: #14476
Signed-off-by: Douglas Fuller <>

Revision 46d626d9 (diff)
Added by Douglas Fuller over 5 years ago

rbd: remove canceled tasks from timer thread

When canceling scheduled tasks using the timer thread, TaskFinisher::cancel
does not call SafeTimer::cancel_event, so events fire anyway. Add this call.

Fixes: #14476
Signed-off-by: Douglas Fuller <>
(cherry picked from commit 2aa0f318c862dbe3027d74d345671506605778eb)

Revision f870ba9a (diff)
Added by Douglas Fuller over 5 years ago

rbd: remove canceled tasks from timer thread

When canceling scheduled tasks using the timer thread, TaskFinisher::cancel
does not call SafeTimer::cancel_event, so events fire anyway. Add this call.

Fixes: #14476
Signed-off-by: Douglas Fuller <>
(cherry picked from commit 2aa0f318c862dbe3027d74d345671506605778eb)

History

#2 Updated by Douglas Fuller over 5 years ago

  • Status changed from New to Fix Under Review

#3 Updated by Jason Dillaman over 5 years ago

  • Backport set to hammer, infernalis

#4 Updated by Douglas Fuller over 5 years ago

  • Status changed from Fix Under Review to Pending Backport

#5 Updated by Loïc Dachary over 5 years ago

  • Copied to Backport #14552: infernalis: rbd: TaskFinisher::cancel should remove event from SafeTimer added

#6 Updated by Loïc Dachary over 5 years ago

  • Copied to Backport #14553: hammer: rbd: TaskFinisher::cancel should remove event from SafeTimer added

#7 Updated by Loïc Dachary over 5 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF