Project

General

Profile

Actions

Bug #14368

closed

mon: paxos is_recovering calc error

Added by weijun duan over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
ceph-deploy
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

    enum {
    /**
     * Leader/Peon is in Paxos' Recovery state
     */
    STATE_RECOVERING,
    /**
     * Leader/Peon is idle, and the Peon may or may not have a valid lease.
     */
    STATE_ACTIVE,
    /**
    ...
  /**
   * Check if we are recovering.
   *
   * @return 'true' if we are on the Recovering state; 'false' otherwise.
   */
  bool is_recovering() const { return (state & STATE_RECOVERING); }

STATE_RECOVERING is 0 not 1 so should be

bool is_recovering() const { return (state == STATE_RECOVERING); }

Actions #1

Updated by Kefu Chai over 8 years ago

  • Status changed from New to Fix Under Review
Actions #2

Updated by Kefu Chai over 8 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF