Project

General

Profile

Actions

Bug #14187

closed

fs: fix return code of mkfs

Added by xie xingguo over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

int FileStore::mkfs()
if (::fsync(fsid_fd) < 0) {
ret = errno;
derr << "mkfs: close failed: can't write fsid: "
<< cpp_strerror(ret) << dendl;
goto close_fsid_fd;
}

Shall return a negative error code instead.

Actions #1

Updated by Sage Weil over 8 years ago

  • Status changed from New to Resolved
Actions

Also available in: Atom PDF