Actions
Bug #14084
closedrbd:when ctx_budget is empty,the logical assertion may arise in the function Objecter::_op_submit_with_budget
Status:
Won't Fix
Priority:
Normal
Assignee:
-
Target version:
-
% Done:
0%
Source:
Community (user)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Although "ctx_budget = NULL" && "initialize the op->ctx_budgeted = false" assertions will not trigger calls * ctx_budget appear ,
But the user doesn't have to understand this relationship, therefore may appear op - > ctx_budgeted is set to true, the trigger to get address blank
ceph_tid_t Objecter::_op_submit_with_budget(Op *op, RWLock::Context& lc, int *ctx_budget)
{
...
if (!op->ctx_budgeted || (ctx_budget && (*ctx_budget == -1))) {
int op_budget = _take_op_budget(op);
// take and pass out the budget for the first OP
// in the context session
if (ctx_budget && (*ctx_budget == -1)) {
*ctx_budget = op_budget;
}
}
...
Updated by huanwen ren over 8 years ago
Assertion is not going to happen, but ctx_budget = NULL, run "int op_budget = _take_op_budget (op);" Is superfluous, and affect the invocation performance
Updated by Nathan Cutler over 8 years ago
- Status changed from New to Fix Under Review
Updated by Jason Dillaman over 8 years ago
- Status changed from Fix Under Review to Won't Fix
Actions