Project

General

Profile

Actions

Bug #13955

closed

/usr/libexec/ceph/ceph-osd-prestart.sh called with incorrect parameters

Added by Sebastien FOUTREL over 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

build Ceph for Debian Jessie from github
ceph version 9.2.0 (bb2ecea240f3a1d525bcb35670cb07bd1f0ca299)

/lib/systemd/system/ceph-osd@.service
contains
ExecStartPre=/usr/libexec/ceph/ceph-osd-prestart.sh --cluster ${CLUSTER} --id %i --setuser ceph --setgroup ceph

but /usr/libexec/ceph/ceph-osd-prestart.sh do not manage parameters --setuser and --setgroup

/usr/libexec/ceph/ceph-osd-prestart.sh --cluster ceph --id 9 --setuser ceph --setgroup ceph
getopt: unrecognized option '--setuser'
getopt: unrecognized option '--setgroup'

Actions #1

Updated by Loïc Dachary about 8 years ago

  • Target version deleted (v9.2.1)
Actions #2

Updated by Nathan Cutler about 8 years ago

  • Project changed from Ceph to devops
Actions #3

Updated by Tim Small about 8 years ago

Sebastien FOUTREL wrote:

build Ceph for Debian Jessie from github
ceph version 9.2.0 (bb2ecea240f3a1d525bcb35670cb07bd1f0ca299)

This is also present on Centos 7 using the current Ceph-provided packages for Infernalis:

ceph-osd-prestart.sh928: getopt: unrecognized option '--setuser'
ceph-osd-prestart.sh928: getopt: unrecognized option '--setgroup'

[root@nutmeg ~]# grep prestart /usr/lib/systemd/system/ceph-osd@.service
ExecStartPre=/usr/libexec/ceph/ceph-osd-prestart.sh --cluster ${CLUSTER} --id %i --setuser ceph --setgroup ceph
[root@nutmeg ~]# rpm -qf /usr/lib/systemd/system/ceph-osd@.service
ceph-9.2.1-0.el7.x86_64
[root@nutmeg ~]# rpm -qf /usr/libexec/ceph/ceph-osd-prestart.sh
ceph-9.2.1-0.el7.x86_64
[root@nutmeg ~]# rpm -qi ceph-9.2.1-0.el7.x86_64
Name : ceph
Epoch : 1
Version : 9.2.1
Release : 0.el7
Architecture: x86_64
Install Date: Tue 15 Mar 2016 09:39:56 GMT
Group : Unspecified
Size : 94269530
License : LGPL-2.1 and CC-BY-SA-1.0 and GPL-2.0 and BSL-1.0 and GPL-2.0-with-autoconf-exception and BSD-3-Clause and MIT
Signature : RSA/SHA1, Fri 26 Feb 2016 13:04:47 GMT, Key ID e84ac2c0460f3994
Source RPM : ceph-9.2.1-0.el7.src.rpm
Build Date : Wed 24 Feb 2016 23:18:56 GMT
Build Host : centos7-huge--e3e2845a-1d22-4890-9503-bcd4fd35434a.localdomain
Relocations : (not relocatable)
URL : http://ceph.com/
Summary : User space components of the Ceph file system

Actions #4

Updated by Nathan Cutler about 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Nathan Cutler
  • Source changed from other to Community (user)

The --setuser and --setgroup options were added to the ceph-osd-prestart.sh call in https://github.com/ceph/ceph/commit/7c9fdf44f2c18659a0bcc03f7b98dafdf9f54448 but that script does not support the --setuser and --setgroup options.

I peeked at how the script is being called in upstart/ceph-osd.conf and these options are not being provided there. I don't think they are necessary, and if they are they would need to be implemented in the script somehow.

Actions #5

Updated by Nathan Cutler about 8 years ago

  • Status changed from In Progress to Pending Backport
  • Backport set to infernalis
Actions #6

Updated by Nathan Cutler about 8 years ago

  • Status changed from Pending Backport to Fix Under Review
Actions #8

Updated by Nathan Cutler almost 8 years ago

  • Status changed from Fix Under Review to Resolved
  • Backport deleted (infernalis)
Actions

Also available in: Atom PDF