Project

General

Profile

Actions

Bug #13943

closed

ceph-disk: prepare with partition doesn't set or validate GUIDs

Added by David Disseldorp over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Low
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

"ceph-disk prepare" can be fed a block device (e.g. /dev/sda), or a partition (e.g. /dev/sda1) as a device argument.
When provided a block device argument, ceph-disk partitions the device, and sets the corresponding GPT GUIDS, based on whether the partition is data, journal, dmcrypt, etc.
However, if ceph-disk is a given partition device argument it leaves the GPT GUID as is, and doesn't check that the partition's GPT GUID matches the prepared partition type. As a result, components that rely on the partition GUID (e.g. udev) may fail.

I plan on proposing a patch that dumps a loud warning if "ceph-disk prepare" is called with a partition device argument, and the partition device's GUID doesn't match the expected Ceph reserved value.

Actions #1

Updated by David Disseldorp over 8 years ago

David Disseldorp wrote:
...

I plan on proposing a patch that dumps a loud warning if "ceph-disk prepare" is called with a partition device argument, and the partition device's GUID doesn't match the expected Ceph reserved value.

Proposed via:
https://github.com/ceph/ceph/pull/6760

Actions #2

Updated by Loïc Dachary over 8 years ago

  • Status changed from New to Fix Under Review
Actions #3

Updated by Loïc Dachary over 8 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF