Project

General

Profile

Backport #13769

EC async "fast read" patchset for hammer (EC read latency improvements)

Added by Tushar Gohad almost 4 years ago. Updated over 2 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Target version:
-
Release:
hammer

Description

Backport EC "fast read" patches from master:

29a1d511 ec: add support for fast read on PGBackend/ECBackend async read

856b39df mon: add a new pool setting to configure fast read for EC pool

2f9f7e2d mon: add a configuration for default fast read setting

History

#1 Updated by Tushar Gohad almost 4 years ago

Backport EC "fast read" patches from master:

Correct commit IDs:

131214dc ec: add support for fast read on PGBackend/ECBackend async read

5eb2a77d mon: add a new pool setting to configure fast read for EC pool

54090f18 mon: add a configuration for default fast read setting

#5 Updated by Tushar Gohad almost 4 years ago

@smithfarm, I meant to backport just https://github.com/ceph/ceph/pull/5309. Let me know if you think entire 5173 needs to be backported.

#6 Updated by Loic Dachary almost 4 years ago

  • Priority changed from High to Normal

#7 Updated by Samuel Just almost 4 years ago

Part of the discussion needs to be how well it's currently tested in master (and therefore in hammer after the backport). This also means there should at a bare minimum be a ceph-qa-suite backport along with this one.

#8 Updated by Samuel Just almost 4 years ago

Apparently fast-read does not have tests in ceph-qa-suite. That is very bad, I've got a wip-fast-read branch now that adds it to one of the tests and I'm running it. We absolutely must have excellent test coverage in master before we consider backporting it. Do not backport it until we have tests.

#9 Updated by Tushar Gohad almost 4 years ago

Samuel Just wrote:

Apparently fast-read does not have tests in ceph-qa-suite. That is very bad, I've got a wip-fast-read branch now that adds it to one of the tests and I'm running it. We absolutely must have excellent test coverage in master before we consider backporting it. Do not backport it until we have tests.

Agreed, Sam that this needs adequate test coverage. Let me know how I can help get this done faster (I am "tsg" on IRC).

On some of the testing that's already been done on master and hammer: Guang Yang (Yahoo) can chime in on their testing. They covered some reports here http://yahooeng.tumblr.com/post/116391291701/yahoo-cloud-object-store-object-storage-at - I will also ask Guang to comment on this issue. At Intel, we have tested the hammer backport for a telco POC and Alcatel Lucent is testing it at the moment in their labs.

#10 Updated by Guang Yang almost 4 years ago

We have a ceph-qa-suite for the fast read - https://github.com/ceph/ceph-qa-suite/pull/503, is that enough?

#11 Updated by Nathan Cutler almost 4 years ago

Sam, can this be backported to hammer now?

#12 Updated by Nathan Cutler almost 4 years ago

  • File firefox.desktop added

The three commits to be cherry-picked are listed in http://tracker.ceph.com/issues/13769#note-1

Sam cannot get at the teuthology cluster, because it is on a truck, so he can't check if it's really being tested.

Programmed myself a reminder to ping Sam again next week.

#13 Updated by Nathan Cutler almost 4 years ago

  • File deleted (firefox.desktop)

#14 Updated by Loic Dachary over 3 years ago

  • Target version deleted (v0.94.6)

#15 Updated by Loic Dachary over 3 years ago

@Guang Yang is https://github.com/ceph/ceph-qa-suite/pull/503 backported to hammer ?

#16 Updated by Loic Dachary over 3 years ago

  • Status changed from New to In Progress

#17 Updated by Loic Dachary over 3 years ago

@Tushar Gohad do you have a pull request to backport this to hammer ?

#18 Updated by Tushar Gohad over 3 years ago

Loic Dachary wrote:

@Tushar Gohad do you have a pull request to backport this to hammer ?

Thanks for the reminder- I will submit the both the ceph-qa-suite and ceph requests today.

#19 Updated by Loic Dachary over 3 years ago

  • Status changed from In Progress to New

Cool, please update the description with a URL to the pull request when you do so and switch the status back to In Progress. Thanks ;-)

#20 Updated by Nathan Cutler over 3 years ago

@Tushar Gohad: ping?

#21 Updated by Nathan Cutler over 3 years ago

  • Status changed from New to Need More Info

#22 Updated by Samuel Just over 3 years ago

Is there still anyone who feels strongly about backporting fast_read? I'd really prefer not to...

#23 Updated by Sage Weil over 2 years ago

  • Status changed from Need More Info to Rejected

guess not!

Also available in: Atom PDF