https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2015-11-10T07:44:30ZCeph Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=612802015-11-10T07:44:30ZLoïc Dacharyloic@dachary.org
<ul></ul><p><a class="external" href="https://github.com/ceph/ceph/pull/6312">https://github.com/ceph/ceph/pull/6312</a> may have introduced a regression</p> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=612812015-11-10T07:59:04ZLoïc Dacharyloic@dachary.org
<ul></ul><code>
./ceph-mon --id a --chdir= --mon-osd-full-ratio=.99 --mon-data-avail-crit=1 --erasure-code-dir=.libs --mon-data=mkfs/a --log-file=mkfs/a/log --mon-cluster-log-file=mkfs/a/log --run-dir=mkfs/a --pid-file=mkfs/a/pidfile --public-addr 127.0.0.1:7110
</code>
<pre>
2015-11-10 08:55:19.362228 7fb8fc118780 -1 mon/AuthMonitor.cc: In function 'virtual void AuthMonitor::create_initial()' thread 7fb8fc118780 time 2015-11-10 08:55:19.361259
mon/AuthMonitor.cc: 101: FAILED assert(ret == 0)
ceph version 9.2.0-523-g866d0a0 (866d0a0892dcfcb3d636a6fab0da4637e8efb4d1)
1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x8b) [0x7fb8fbcd955b]
2: (AuthMonitor::create_initial()+0x53b) [0x7fb8fbbb4fcb]
3: (PaxosService::_active()+0x516) [0x7fb8fbaebc26]
4: (PaxosService::election_finished()+0x67) [0x7fb8fbaec007]
5: (Monitor::win_election(unsigned int, std::set<int, std::less<int>, std::allocator<int> >&, unsigned long, MonCommand const*, int, std::set<int, std::less<int>, std::allocator<int> > const*)+0x236) [0x7fb8fbaa6a76]
6: (Monitor::win_standalone_election()+0x14d) [0x7fb8fbaa6e8d]
7: (Monitor::bootstrap()+0xa2b) [0x7fb8fbaa79eb]
8: (Monitor::init()+0x184) [0x7fb8fbaa7ce4]
9: (main()+0x23fc) [0x7fb8fba67e8c]
10: (__libc_start_main()+0xf5) [0x7fb8f958cec5]
11: (()+0x1a309a) [0x7fb8fba7709a]
NOTE: a copy of the executable, or `objdump -rdS <executable>` is needed to interpret this.
</pre> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=612822015-11-10T08:11:19ZLoïc Dacharyloic@dachary.org
<ul></ul><p>Reverting <a class="external" href="https://github.com/ceph/ceph/commit/66b7b920cf5a0a9c71212573ef47fb2c7ea9b5ff">https://github.com/ceph/ceph/commit/66b7b920cf5a0a9c71212573ef47fb2c7ea9b5ff</a>, the test passes</p> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=612832015-11-10T08:31:58ZLoïc Dacharyloic@dachary.org
<ul><li><strong>Subject</strong> changed from <i>test/mon/mkfs.sh fails</i> to <i>MonitorDBStore::get semantic change triggers regressions</i></li></ul> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=612842015-11-10T08:33:26ZLoïc Dacharyloic@dachary.org
<ul><li><strong>Assignee</strong> changed from <i>Loïc Dachary</i> to <i>Piotr Dalek</i></li></ul> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=612852015-11-10T08:34:47ZLoïc Dacharyloic@dachary.org
<ul></ul><p><a class="external" href="https://github.com/ceph/ceph/commit/66b7b920cf5a0a9c71212573ef47fb2c7ea9b5ff">https://github.com/ceph/ceph/commit/66b7b920cf5a0a9c71212573ef47fb2c7ea9b5ff</a> changed the behavior of the function. It previously never returned ENOENT because the key was inserted, always and the size of out was always 1. The callers have to be changed to deal with the change.</p> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=612862015-11-10T08:55:20ZPiotr Dalekpiotr.dalek@corp.ovh.com
<ul></ul><p>Loic Dachary wrote:</p>
<blockquote>
<p><a class="external" href="https://github.com/ceph/ceph/commit/66b7b920cf5a0a9c71212573ef47fb2c7ea9b5ff">https://github.com/ceph/ceph/commit/66b7b920cf5a0a9c71212573ef47fb2c7ea9b5ff</a> changed the behavior of the function. It previously never returned ENOENT because the key was inserted, always and the size of out was always 1. The callers have to be changed to deal with the change.</p>
</blockquote>
<p>This calls for a larger patch which cannot be delivered fast. Instead, I'll restore the old behavior and then propose a patch that will fix this globally.</p> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=613152015-11-10T11:53:16ZPiotr Dalekpiotr.dalek@corp.ovh.com
<ul></ul><p>Pushed <a class="external" href="https://github.com/ceph/ceph/pull/6522">https://github.com/ceph/ceph/pull/6522</a> with temporary fix.</p> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=614952015-11-12T16:09:58ZLoïc Dacharyloic@dachary.org
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=614972015-11-12T16:13:33ZLoïc Dacharyloic@dachary.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>In Progress</i></li></ul> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=615362015-11-13T12:09:02ZPiotr Dalekpiotr.dalek@corp.ovh.com
<ul></ul><p>Pushed <a class="external" href="https://github.com/ceph/ceph/pull/6564">https://github.com/ceph/ceph/pull/6564</a> which fixes this, and other issues.</p> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=615382015-11-13T13:08:29ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Fix Under Review</i></li></ul> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=616712015-11-17T15:11:58ZSage Weilsage@newdream.net
<ul><li><strong>Assignee</strong> changed from <i>Piotr Dalek</i> to <i>Joao Eduardo Luis</i></li></ul> Ceph - Bug #13742: MonitorDBStore::get semantic change triggers regressionshttps://tracker.ceph.com/issues/13742?journal_id=636922016-01-07T11:52:08ZJoao Eduardo Luis
<ul><li><strong>Category</strong> set to <i>Monitor</i></li><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Resolved</i></li></ul>