Bug #13625
warning: comparison between signed and unsigned
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:
Description
Lots of annoying build warnings now on master caused by 0bf2a79e "messages/MOSDOp: fix reqid encoding/decoding"
./messages/MOSDOp.h: In member function ‘osd_reqid_t MOSDOp::get_reqid() const’:
./messages/MOSDOp.h:102:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
assert(reqid.inc == client_inc); // decode() should have done this
^
./include/assert.h:144:5: note: in definition of macro ‘assert’
((expr) \
^
Associated revisions
messages/MOSDOp: Cast in assert to eliminate warnings
Fixes: #13625
Caused by 0bf2a79e
Signed-off-by: David Zafman <dzafman@redhat.com>
History
#1 Updated by David Zafman about 4 years ago
- Status changed from New to Fix Under Review
- Assignee set to David Zafman
#2 Updated by David Zafman about 4 years ago
- Status changed from Fix Under Review to Resolved
39fb7f12cb3a902c3a65c9fe59a00821f3b205a8