Project

General

Profile

Actions

Bug #13554

closed

make dist fails with : rocksdb/tools/rdb/rdb.cc v8.h: No such file or directory

Added by Loïc Dachary over 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

make dist after make check occasionally (once every 20 runs or so) fails with the following (see http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/8526/console for an example)

make  dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins'
if test -d "ceph-9.1.0"; then find "ceph-9.1.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "ceph-9.1.0" || { sleep 5 && rm -rf "ceph-9.1.0"; }; else :; fi
test -d "ceph-9.1.0" || mkdir "ceph-9.1.0" 
 (cd src && make  top_distdir=../ceph-9.1.0 distdir=../ceph-9.1.0/src \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins/src'
./make_version -g ./.git_version
if [ -n "$NO_VERSION" ] ; then \
    ./make_version -g ./.git_version -c ./ceph_ver.h -n ; \
else \
    ./make_version -g ./.git_version -c ./ceph_ver.h ; \
fi
ccache g++ -Wall -g -std=gnu++11    rocksdb/tools/rdb/rdb.cc   -o rocksdb/tools/rdb/rdb
[01m[Krocksdb/tools/rdb/rdb.cc:5:16:[m[K [01;31m[Kfatal error: [m[Kv8.h: No such file or directory
 #include <v8.h>
[01;32m[K                ^[m[K
compilation terminated.
make[2]: *** [rocksdb/tools/rdb/rdb] Error 1
make[2]: Leaving directory `/home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory `/home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins'
make: *** [dist] Error 2
Actions #4

Updated by Loïc Dachary over 8 years ago

  rocksdb/tools/rdb/rdb \
  rocksdb/tools/rdb/rdb.cc \

it tries to compile rocksdb/tools/rdb/rdb with rocksdb/tools/rdb/rdb.cc and fails.
Actions #5

Updated by Loïc Dachary over 8 years ago

  • Status changed from 12 to Resolved
  • Assignee set to Kefu Chai
Actions #6

Updated by Kefu Chai over 8 years ago

per the analysis of Loïc,

if the timestamp of rbd is older than that of rbd.cc, "make dist" will follow the implicit rule, and try to compile rbd.cc. but rbd.cc needs NodeJS to compile.

Actions #7

Updated by Kefu Chai over 8 years ago

  • Status changed from Resolved to 12

aa844e58 reverts the fix.

Actions #8

Updated by Venky Shankar over 8 years ago

https://github.com/ceph/ceph/pull/7105

With the above patch "make dist" runs successfully.

Actions #9

Updated by Kefu Chai over 8 years ago

  • Status changed from 12 to Resolved
Actions #10

Updated by Kefu Chai almost 8 years ago

  • Status changed from Resolved to Fix Under Review
Actions #11

Updated by Kefu Chai almost 8 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF