Project

General

Profile

Actions
Copy link

Bug #13525

closed

mon: should not set isvalid = true when cephx_verify_authorizer return false

Added by Ruifeng Yang over 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
infernalis,hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

if (authorizer_data.length()) {
  int ret = cephx_verify_authorizer(g_ceph_context, &keyring, iter,
                                    auth_ticket_info, authorizer_reply);
  if (ret >= 0) { //bad!
    session_key = auth_ticket_info.session_key;
    isvalid = true;
  } else {
    dout(0) << "ms_verify_authorizer bad authorizer from mon " << con->get_peer_addr() << dendl;
  }
}

should use bool instead of int
master PR: https://github.com/ceph/ceph/pull/6306

Related issues 2 (0 open — 2 closed)

Copied to Ceph - Backport #13589: infernalis: mon: should not set isvalid = true when cephx_verify_authorizer return falseResolvedSage WeilActions
Copied to Ceph - Backport #13590: mon: should not set isvalid = true when cephx_verify_authorizer return falseResolvedSage WeilActions
Actions
Copy link
 #1

Updated by Kefu Chai over 8 years ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #2

Updated by Sage Weil over 8 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Assignee deleted (Ruifeng Yang)
  • Backport set to infernalis,hammer,firefly
Actions
Copy link
 #3

Updated by Nathan Cutler over 8 years ago

  • Copied to Backport #13589: infernalis: mon: should not set isvalid = true when cephx_verify_authorizer return false added
Actions
Copy link
 #4

Updated by Nathan Cutler over 8 years ago

  • Copied to Backport #13590: mon: should not set isvalid = true when cephx_verify_authorizer return false added
Actions
Copy link
 #5

Updated by Nathan Cutler over 8 years ago

  • Copied to Backport #13591: mon: should not set isvalid = true when cephx_verify_authorizer return false added
Actions
Copy link
 #6

Updated by Loïc Dachary about 8 years ago

  • Backport changed from infernalis,hammer,firefly to infernalis,hammer
Actions
Copy link
 #7

Updated by Loïc Dachary about 8 years ago

  • Copied to deleted (Backport #13591: mon: should not set isvalid = true when cephx_verify_authorizer return false)
Actions
Copy link
 #8

Updated by Loïc Dachary about 8 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link
 #9

Updated by Samuel Just about 8 years ago

  • Related to Bug #13826: segfault from PrebufferedStreambuf::overflow added
Actions
Copy link
 #10

Updated by Kefu Chai about 8 years ago

  • Related to deleted (Bug #13826: segfault from PrebufferedStreambuf::overflow)
Actions
Copy link
 #11

Updated by Kefu Chai about 8 years ago

  • Has duplicate Bug #13826: segfault from PrebufferedStreambuf::overflow added
Actions
Copy link
 #12

Updated by Brad Hubbard about 8 years ago

  • Has duplicate deleted (Bug #13826: segfault from PrebufferedStreambuf::overflow)
Actions
Copy link

Also available in: Atom PDF