Project

General

Profile

Bug #13220

rbd-replay-prep: crashes on incorrect trace file

Added by Josh Durgin about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jason Dillaman
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

A useful error message should be displayed instead of asserting when something like this is run:

rbd-replay-prep ~/traces/ust/uid/0/64-bit/channel0_0
...
FAILED assert(trace_handle >= 0)

Related issues

Copied to rbd - Backport #13460: rbd-replay-prep: crashes on incorrect trace file Resolved

Associated revisions

Revision a1e99f06 (diff)
Added by Jason Dillaman about 7 years ago

rbd-replay-prep: avoid using assert statements on user inputs

Fixes: #13220
Backport: hammer
Signed-off-by: Jason Dillaman <>

Revision a856bee2 (diff)
Added by Jason Dillaman about 7 years ago

rbd-replay-prep: avoid using assert statements on user inputs

Fixes: #13220
Backport: hammer
Signed-off-by: Jason Dillaman <>
(cherry picked from commit a1e99f06a78d7cf2ecc0c8e9fbc3331e4e4f18f7)

History

#1 Updated by Jason Dillaman about 7 years ago

  • Status changed from New to In Progress

#2 Updated by Jason Dillaman about 7 years ago

  • Assignee set to Jason Dillaman

#3 Updated by Jason Dillaman about 7 years ago

  • Status changed from In Progress to Fix Under Review
  • Backport set to hammer

#4 Updated by Jason Dillaman about 7 years ago

  • Status changed from Fix Under Review to Pending Backport

#5 Updated by Jason Dillaman about 7 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF