Backport #12959
closedudev: add devicemapper to partuuid-workaround
Updated by Nathan Cutler over 8 years ago
- Status changed from New to Rejected
Hi Joe: We don't ordinarily backport features - only bugfixes. Please discuss this with Loic Dachary (loicd on #ceph-devel, or loic@dachary.org) first; maybe he will make an exception. Nathan
Updated by Joe Julian over 8 years ago
Nathan Cutler wrote:
Hi Joe: We don't ordinarily backport features - only bugfixes. Please discuss this with Loic Dachary (loicd on #ceph-devel, or loic@dachary.org) first; maybe he will make an exception. Nathan
This is a bugfix. dm-* is ignored and shouldn't be. With it ignored, lvm lv's cannot be used as osds.
Updated by Loïc Dachary over 8 years ago
- Assignee set to Loïc Dachary
I'm not sure https://github.com/ceph/ceph/commit/42ad86e14e352f2a3a33e774224f1789f268da83 will be enough for LVM volumes to be properly handled in firefly. Nathan is right when he says this is a feature : LVM volumes are not supported by Firefly and adding support is a new feature. The other way to look at is is to consider than Ceph should work with all existing block devices and that any type of block that fails should be treated as a bug.
Although we appreciate (as backporters) that you need that to work with firefly, it is not for us to decide if this is a valid backport since there are indeed two ways to look at it.
I suggest you send a mail to ceph-devel so that a lead (presumably Sage or Sam) can decide which way to go. In the meantime I'll set that as "Need More Info" and you can add to the comments when the ceph-devel thread reaches a conclusion.
Updated by Loïc Dachary over 8 years ago
- Status changed from New to Need More Info
Updated by Loïc Dachary over 8 years ago
- Status changed from Need More Info to In Progress
- Release deleted (
firefly)
Updated by Greg Farnum almost 7 years ago
- Status changed from In Progress to Closed
The referenced PR didn't get merged. There is ongoing work to support LVM stuff now.