Project

General

Profile

Bug #12958

rgw: orphan tool should be careful about removing head objects

Added by Yehuda Sadeh over 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
High
Assignee:
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
firefly,hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The following scenario is possible:

- object exists
- building raw map of objects (pgls)
- object is removed
- building map of linked objects
- object is uploaded again
- object is removed by the tool

Either don't remove the immutable head part, or be a bit more careful about removing it


Related issues

Copied to rgw - Backport #13538: rgw: orphan tool should be careful about removing head objects Resolved
Copied to rgw - Backport #13539: rgw: orphan tool should be careful about removing head objects Rejected

Associated revisions

Revision 030f697d (diff)
Added by Yehuda Sadeh about 7 years ago

rgw: orphan tool shouldn't clean up head objects

Fixes: #12958

Head objects are mutable, so removing them can race with object removal
and a later recreation, so we might end up cleaning them up when we don't
need to.

Signed-off-by: Yehuda Sadeh <>

Revision 99b4d1df (diff)
Added by Yehuda Sadeh about 7 years ago

rgw: orphan tool shouldn't clean up head objects

Fixes: #12958

Head objects are mutable, so removing them can race with object removal
and a later recreation, so we might end up cleaning them up when we don't
need to.

Signed-off-by: Yehuda Sadeh <>
(cherry picked from commit 030f697d196df9963ecf4f05f727da4798c583dc)

History

#1 Updated by Matt Benjamin about 7 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Casey Bodley

pr #6044

#2 Updated by Yehuda Sadeh about 7 years ago

  • Status changed from Fix Under Review to Pending Backport

#3 Updated by Nathan Cutler about 7 years ago

  • Backport set to firefly,hammer

#4 Updated by Nathan Cutler about 7 years ago

Yehuda: hammer and firefly, or just hammer?

#6 Updated by Loïc Dachary almost 7 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF