Bug #12753: cls_cephfs_client encodes time_t directly - CephFS - Ceph

Actions

Copy link

Bug #12753

closed

cls_cephfs_client encodes time_t directly

Added by Sage Weil over 8 years ago. Updated over 8 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Category:

Target version:

% Done:

Source:

Q/A

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

Labels (FS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

fail to build on i386.

we should never encode time_t directly.. cast to uint32_t or uint64_t so it is sized explicitly.

cls/cephfs/cls_cephfs_client.cc: In static member function 'static int ClsCephFSClient::fetch_inode_accumulate_result(librados::IoCtx&, const string&, inode_backtrace_t*, AccumulateResult*)':
cls/cephfs/cls_cephfs_client.cc:112:55: error: no matching function for call to 'decode(time_t&, ceph::buffer::list::iterator&)'
cls/cephfs/cls_cephfs_client.cc:112:55: note: candidates are: