Bug #12465
Log::reopen_log_file() must take the flusher lock to avoid closing an fd ::_flush() is still using
0%
Related issues
Associated revisions
Log::reopen_log_file: take m_flush_mutex
Otherwise, _flush() might continue to write to m_fd after it's closed.
This might cause log data to go to a data object if the filestore then
reuses the fd during that time.
Fixes: #12465
Backport: firefly, hammer
Signed-off-by: Samuel Just <sjust@redhat.com>
Log::reopen_log_file: take m_flush_mutex
Otherwise, _flush() might continue to write to m_fd after it's closed.
This might cause log data to go to a data object if the filestore then
reuses the fd during that time.
Fixes: #12465
Backport: firefly, hammer
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 8778ab3a1ced7fab07662248af0c773df759653d)
Log::reopen_log_file: take m_flush_mutex
Otherwise, _flush() might continue to write to m_fd after it's closed.
This might cause log data to go to a data object if the filestore then
reuses the fd during that time.
Fixes: #12465
Backport: firefly, hammer
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 8778ab3a1ced7fab07662248af0c773df759653d)
- modified to drop m_flush_mutex_holder, which isn't present in firefly
Log::reopen_log_file: take m_flush_mutex
Otherwise, _flush() might continue to write to m_fd after it's closed.
This might cause log data to go to a data object if the filestore then
reuses the fd during that time.
Fixes: #12465
Backport: firefly, hammer
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 8778ab3a1ced7fab07662248af0c773df759653d)
History
#1 Updated by Samuel Just over 8 years ago
Part of this bug should be to add a background task to the thrasher to constantly send sighup to the daemon processes.
#3 Updated by Samuel Just over 8 years ago
- Status changed from New to In Progress
#4 Updated by Nathan Cutler over 8 years ago
- Backport set to firefly,hammer
master PR: https://github.com/ceph/ceph/pull/5348
#5 Updated by Sage Weil over 8 years ago
- Status changed from In Progress to Pending Backport
- Assignee deleted (
Samuel Just) - Source changed from other to Development
#6 Updated by Sage Weil over 8 years ago
- Status changed from Pending Backport to Resolved