Bug #12166
ceph.spec.in: 50-rbd.rules conditional is wrong
0%
Description
The conditional currently says:
%if 0%{?rhel} >= 7 || 0%{?fedora} /usr/lib/udev/rules.d/50-rbd.rules %else /lib/udev/rules.d/50-rbd.rules %endif
which on SUSE/openSUSE has the effect of putting 50-rbd.rules in /lib/udev/rules.d
, regardless of distro version.
The conditional governing the install
is similarly inadequate.
And the conditionals for the other udev rules files also suffer from the same issue.
Related issues
Associated revisions
ceph.spec.in: use _udevrulesdir to eliminate conditionals
The conditionals governing where 50-rbd.rules is installed were not doing the
right thing on SUSE distros.
Start using the %_udevrulesdir RPM macro, while taking care that it is defined
and set to the right value. Use it to eliminate some conditionals around other
udev rules files as well.
http://tracker.ceph.com/issues/12166 Fixes: #12166
Signed-off-by: Nathan Cutler <ncutler@suse.com>
ceph.spec.in: use _udevrulesdir to eliminate conditionals
The conditionals governing where 50-rbd.rules is installed were not doing the
right thing on SUSE distros.
Start using the %_udevrulesdir RPM macro, while taking care that it is defined
and set to the right value. Use it to eliminate some conditionals around other
udev rules files as well.
http://tracker.ceph.com/issues/12166 Fixes: #12166
Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 8aa758ee7a14e93ded1d55b4aca7a54aa47d7174)
Conflicts:
ceph.spec.in
hammer does not yet have _with_systemd or ceph_daemon.py
ceph.spec.in: use _udevrulesdir to eliminate conditionals
The conditionals governing where 50-rbd.rules is installed were not doing the
right thing on SUSE distros.
Start using the %_udevrulesdir RPM macro, while taking care that it is defined
and set to the right value. Use it to eliminate some conditionals around other
udev rules files as well.
http://tracker.ceph.com/issues/12166 Fixes: #12166
Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 8aa758ee7a14e93ded1d55b4aca7a54aa47d7174)
Conflicts:
ceph.spec.in
master spec file has diverged significantly from firefly
History
#1 Updated by Nathan Cutler almost 9 years ago
- Status changed from New to Fix Under Review
- Assignee changed from Nathan Cutler to Ken Dreyer
#2 Updated by Nathan Cutler over 8 years ago
- Status changed from Fix Under Review to Resolved
#3 Updated by Nathan Cutler over 8 years ago
- Status changed from Resolved to Pending Backport
#4 Updated by Nathan Cutler over 8 years ago
- Status changed from Pending Backport to Resolved
#5 Updated by Nathan Cutler over 8 years ago
- Duplicated by Bug #12164: ceph.spec.in: 50-rbd.rules conditional is wrong added