ENOSPC hidden by cache not detected by callers of flatten
Related to #12018, 'rbd flatten' doesn't detect the error flushing the cache, since it is implicit in closing the image. rbd_close() is void, so it cannot detect the error with the existing function.
We may need to add a rbd_close2() that has a return value.
librbd: closing images now returns a result code
Added new librbd::Image::close method to allow checking the close result
when using the C++ librbd library. rbd_close is no longer hard-coded to
Signed-off-by: Jason Dillaman <firstname.lastname@example.org>
Once #12018 is fixed this will block, but we should be able to detect other errors that arise due to bugs (generally no errors should propagate to this layer).
- Priority changed from Normal to High
- Status changed from New to In Progress
- Assignee set to Jason Dillaman
rbd_close returns a status that is hard-coded to 0. Will add an optional close method to librbd::Image.
- Status changed from In Progress to Fix Under Review
- Status changed from Fix Under Review to Resolved
Also available in: Atom