Tools » teuthology

Prior to https://github.com/ceph/ceph-qa-suite/pull/459, ceph_manager.py was missing the log global variable. It showed in http://qa-proxy.ceph.com/teuthology/teuthology-2015-06-10_09:19:27-powercycle-firefly-testing-basic-multi/928246/teuthology.log as

2015-06-10T15:49:51.000 INFO:tasks.thrashosds:joining thrashosds
2015-06-10T15:49:51.000 ERROR:teuthology.run_tasks:Manager failed: thrashosds
Traceback (most recent call last):
  File "/home/teuthworker/src/teuthology_master/teuthology/run_tasks.py", line 125, in run_tasks
    suppress = manager.__exit__(*exc_info)
  File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/var/lib/teuthworker/src/ceph-qa-suite_firefly/tasks/thrashosds.py", line 183, in task
    thrash_proc.do_join()
  File "/var/lib/teuthworker/src/ceph-qa-suite_firefly/tasks/ceph_manager.py", line 360, in do_join
    self.thread.get()
  File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 308, in get
    raise self._exception
NameError: global name 'log' is not defined
2015-06-10T15:49:51.030 DEBUG:teuthology.run_tasks:Unwinding manager ceph

Which is unrelated to the actual error. Although exit() is called with all three elements of the stack trace, it only shows the global message for some reason.

https://github.com/ceph/teuthology/blob/master/teuthology/run_tasks.py#L125