https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2011-06-21T20:40:32ZCeph Ceph - Feature #1190: codingstyle documenthttps://tracker.ceph.com/issues/1190?journal_id=45512011-06-21T20:40:32ZSage Weilsage@newdream.net
<ul><li><strong>Target version</strong> changed from <i>v0.31</i> to <i>v0.32</i></li></ul> Ceph - Feature #1190: codingstyle documenthttps://tracker.ceph.com/issues/1190?journal_id=46352011-06-28T13:43:36ZSage Weilsage@newdream.net
<ul></ul><p>Looks basically fine to me (tho i didn't read the whole thing). It leaves a lot of stuff unspecified, though. Notably, they allow all of</p>
<pre><code>if (condition) foo;<br /> if (condition)<br /> foo;<br /> if (condition {<br /> foo;<br /> }</code></pre>
<p>I like the linux kernel guidelines, which specify</p>
<p>- no single line if (easy to miss when visually scanning code; sadly i did a lot of this in the older mds code)<br />- no braces for single line then block</p>
<p>Both specify that the then and else blocks must neither or both have braces.</p> Ceph - Feature #1190: codingstyle documenthttps://tracker.ceph.com/issues/1190?journal_id=46812011-07-05T08:51:06ZSage Weilsage@newdream.net
<ul><li><strong>translation missing: en.field_position</strong> set to <i>709</i></li></ul> Ceph - Feature #1190: codingstyle documenthttps://tracker.ceph.com/issues/1190?journal_id=47762011-07-05T11:43:01ZSage Weilsage@newdream.net
<ul><li><strong>translation missing: en.field_story_points</strong> set to <i>5</i></li><li><strong>translation missing: en.field_position</strong> deleted (<del><i>720</i></del>)</li><li><strong>translation missing: en.field_position</strong> set to <i>720</i></li></ul> Ceph - Feature #1190: codingstyle documenthttps://tracker.ceph.com/issues/1190?journal_id=48052011-07-05T12:43:09ZSage Weilsage@newdream.net
<ul><li><strong>Assignee</strong> set to <i>Sage Weil</i></li></ul> Ceph - Feature #1190: codingstyle documenthttps://tracker.ceph.com/issues/1190?journal_id=49082011-07-14T11:01:27ZSage Weilsage@newdream.net
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul>