Project

General

Profile

Actions

Feature #1190

closed

codingstyle document

Added by Sage Weil almost 13 years ago. Updated almost 13 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Actions #1

Updated by Sage Weil almost 13 years ago

  • Target version changed from v0.31 to v0.32
Actions #2

Updated by Sage Weil almost 13 years ago

Looks basically fine to me (tho i didn't read the whole thing). It leaves a lot of stuff unspecified, though. Notably, they allow all of

if (condition) foo;
if (condition)
foo;
if (condition {
foo;
}

I like the linux kernel guidelines, which specify

- no single line if (easy to miss when visually scanning code; sadly i did a lot of this in the older mds code)
- no braces for single line then block

Both specify that the then and else blocks must neither or both have braces.

Actions #3

Updated by Sage Weil almost 13 years ago

  • Translation missing: en.field_position set to 709
Actions #4

Updated by Sage Weil almost 13 years ago

  • Translation missing: en.field_story_points set to 5
  • Translation missing: en.field_position deleted (720)
  • Translation missing: en.field_position set to 720
Actions #5

Updated by Sage Weil almost 13 years ago

  • Assignee set to Sage Weil
Actions #6

Updated by Sage Weil almost 13 years ago

  • Status changed from New to Resolved
Actions

Also available in: Atom PDF