Project

General

Profile

Bug #11791

A client opening an image mid-resize can result in the object map being invalidated

Added by Jason Dillaman over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
High
Target version:
-
Start date:
05/27/2015
Due date:
% Done:

0%

Source:
Q/A
Tags:
Backport:
hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

There is a potential race where the object map size on disk does not match the image size on disk. This causes librbd to flag the object map as invalid. A client that doesn't have exclusive ownership of the image shouldn't be able to change the on-disk object map validity flag.


Related issues

Copied to rbd - Backport #12237: A client opening an image mid-resize can result in the object map being invalidated Resolved 05/27/2015

Associated revisions

Revision eb81a6a7 (diff)
Added by Jason Dillaman about 4 years ago

librbd: only update image flags when holding exclusive lock

It was possible for a client to open an image while another client
was shrinking an image. This would result in the former invalidating
the object map on-disk if it openned the image between updating the
image header and resizing the object map.

Fixes: #11791
Backport: hammer
Signed-off-by: Jason Dillaman <>

Revision 27c99ea9 (diff)
Added by Jason Dillaman about 4 years ago

librbd: only update image flags when holding exclusive lock

It was possible for a client to open an image while another client
was shrinking an image. This would result in the former invalidating
the object map on-disk if it openned the image between updating the
image header and resizing the object map.

Fixes: #11791
Backport: hammer
Signed-off-by: Jason Dillaman <>
(cherry picked from commit eb81a6a7e391327ac993fd406443b206a7f7bffc)

History

#1 Updated by Jason Dillaman over 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Jason Dillaman

#2 Updated by Josh Durgin over 4 years ago

  • Priority changed from Normal to High

#3 Updated by Jason Dillaman about 4 years ago

  • Status changed from In Progress to Need Review

#4 Updated by Jason Dillaman about 4 years ago

  • Status changed from Need Review to Pending Backport

#5 Updated by Loic Dachary about 4 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF