Project

General

Profile

Feature #11545

mon: have mon-specific commands under 'ceph mon ...'

Added by Joao Eduardo Luis over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Category:
Monitor
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

There are a bunch of monitor-specific commands that, from the user's perspective, have been kept as commands to the 'ceph' tool.

Examples of this would be:

- 'ceph scrub'
- 'ceph sync force'
- 'ceph compact'

While these make sense if they are preceded by a 'tell mon.X', using 'tell' is not at all required.

The reason for not having these commands under the 'mon' module has been because all commands under the 'mon' module will be handed over to the MonmapMonitor, and these commands are clearly out of the jurisdiction of the MonmapMonitor.

However, as it is I believe it's confusing, as it's not clear at all that these are monitor-specific commands, and I'm positive some users would assume they would have cluster-wide effects.

As such, I'm proposing moving these commands under the 'mon' module. Instead of blindly passing these commands to the MonmapMonitor, we should first check if the command being handled is any of these commands (on Monitor::handle_command()) and then dispatch to MonmapMonitor otherwise.

Associated revisions

Revision 16dcc40c (diff)
Added by Joao Eduardo Luis over 7 years ago

mon: Monitor: use 'ceph mon compact' instead of 'ceph compact'

Makes it easier to identify the command as being related with the
monitor instead of cluster-wide.

This entails adding an exception to module 'mon' in order to have this
command handled by the Monitor class instead of MonmapMonitor (which is
the one traditionally handling 'mon' module commands).

Fixes: #11545

Signed-off-by: Joao Eduardo Luis <>

Revision 574e596f (diff)
Added by Joao Eduardo Luis over 7 years ago

mon: Monitor: use 'ceph mon scrub' instead of 'ceph scrub'

Makes it easier to identify the command as being related with the
monitor instead of cluster-wide.

This entails adding an exception to module 'mon' in order to have this
command handled by the Monitor class instead of MonmapMonitor (which is
the one traditionally handling 'mon' module commands).

Fixes: #11545

Signed-off-by: Joao Eduardo Luis <>

Revision 955dcede (diff)
Added by Joao Eduardo Luis over 7 years ago

mon: Monitor: use 'ceph mon sync force' instead of 'ceph sync force'

Makes it easier to identify the command as being related with the
monitor instead of cluster-wide.

This entails adding an exception to module 'mon' in order to have this
command handled by the Monitor class instead of MonmapMonitor (which is
the one traditionally handling 'mon' module commands).

Fixes: #11545

Signed-off-by: Joao Eduardo Luis <>

Revision 038452e7 (diff)
Added by Joao Eduardo Luis over 7 years ago

mon: Monitor: use 'ceph mon metadata' instead of 'ceph mon_metadata'

'ceph mon_metadata' was added still during this dev cycle, so there is
no need to deprecate it first.

Fixes: #11545

Signed-off-by: Joao Eduardo Luis <>

History

#1 Updated by Joao Eduardo Luis over 7 years ago

  • Status changed from New to In Progress

#2 Updated by Joao Eduardo Luis over 7 years ago

  • Status changed from In Progress to Fix Under Review

#3 Updated by Joao Eduardo Luis over 7 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF