Project

General

Profile

Actions

Bug #11504

closed

CephFS restriction on removing cache tiers is overly strict

Added by John Spray almost 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We prevent removing any cache tier that sits on a cephfs pool, even if the tier has been safely set to 'forward' and flushed.

We should permit removal of the tier if it is set to forward and PGMonitor statistics indicate that it is empty.


Related issues 1 (0 open1 closed)

Copied to CephFS - Backport #13621: CephFS restriction on removing cache tiers is overly strictResolvedNathan CutlerActions
Actions #1

Updated by John Spray almost 9 years ago

  • Source changed from other to Community (user)
Actions #2

Updated by Greg Farnum almost 9 years ago

Mmm, the thing to be careful of here is that we can't remove cache tiers if they're over an EC pool. That whole saga is presumably why the code is overly-restrictive to begin with.

Actions #3

Updated by John Spray almost 9 years ago

Oh yeah, now I remember why we added it :-)

So the condition for permitting removal is that it's set to forward or readonly, it's flushed, and the underlying pool is usable by cephfs (i.e. replicated)

Actions #4

Updated by John Spray almost 9 years ago

  • Status changed from New to Fix Under Review
  • Regression set to No
Actions #5

Updated by Greg Farnum almost 9 years ago

  • Status changed from Fix Under Review to Resolved

commit:5a3da7b891bf18e0f164352dd0010c7969233d72

Actions #6

Updated by Greg Farnum over 8 years ago

  • Status changed from Resolved to Pending Backport
  • Priority changed from Normal to Low

Let's put this in hammer please! We seem to be getting a lot more experimental users lately. :)

Actions #7

Updated by Nathan Cutler over 8 years ago

  • Copied to Backport #13621: CephFS restriction on removing cache tiers is overly strict added
Actions #8

Updated by Nathan Cutler over 8 years ago

  • Backport set to hammer
Actions #9

Updated by Loïc Dachary over 8 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF