Project

General

Profile

Bug #11504

CephFS restriction on removing cache tiers is overly strict

Added by John Spray over 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We prevent removing any cache tier that sits on a cephfs pool, even if the tier has been safely set to 'forward' and flushed.

We should permit removal of the tier if it is set to forward and PGMonitor statistics indicate that it is empty.


Related issues

Copied to CephFS - Backport #13621: CephFS restriction on removing cache tiers is overly strict Resolved

Associated revisions

Revision a50c8f1f (diff)
Added by John Spray over 7 years ago

mon: refine check_remove_tier checks

Fixes: #11504
Signed-off-by: John Spray <>

Revision 31e59fbc (diff)
Added by John Spray about 7 years ago

mon: refine check_remove_tier checks

Fixes: #11504
Signed-off-by: John Spray <>
(cherry picked from commit a50c8f1f2ad8845c7f77110868f9376f2d1ff883)

History

#1 Updated by John Spray over 7 years ago

  • Source changed from other to Community (user)

#2 Updated by Greg Farnum over 7 years ago

Mmm, the thing to be careful of here is that we can't remove cache tiers if they're over an EC pool. That whole saga is presumably why the code is overly-restrictive to begin with.

#3 Updated by John Spray over 7 years ago

Oh yeah, now I remember why we added it :-)

So the condition for permitting removal is that it's set to forward or readonly, it's flushed, and the underlying pool is usable by cephfs (i.e. replicated)

#4 Updated by John Spray over 7 years ago

  • Status changed from New to Fix Under Review
  • Regression set to No

#5 Updated by Greg Farnum over 7 years ago

  • Status changed from Fix Under Review to Resolved

commit:5a3da7b891bf18e0f164352dd0010c7969233d72

#6 Updated by Greg Farnum about 7 years ago

  • Status changed from Resolved to Pending Backport
  • Priority changed from Normal to Low

Let's put this in hammer please! We seem to be getting a lot more experimental users lately. :)

#7 Updated by Nathan Cutler about 7 years ago

  • Copied to Backport #13621: CephFS restriction on removing cache tiers is overly strict added

#8 Updated by Nathan Cutler about 7 years ago

  • Backport set to hammer

#9 Updated by Loïc Dachary almost 7 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF