https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2015-04-14T13:57:02ZCeph devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=506002015-04-14T13:57:02ZKen Dreyerkdreyer@redhat.com
<ul></ul><p>Confirmed; "<code>/usr/bin/ceph</code>" is in ceph-common, but "<code>ceph_argparse.py</code>" is not: <a class="external" href="https://github.com/ceph/ceph/blob/v0.94/debian/ceph-common.install">https://github.com/ceph/ceph/blob/v0.94/debian/ceph-common.install</a></p>
<p>I think the problem is in <a class="external" href="https://github.com/ceph/ceph/commit/2a23eac54957e596d99985bb9e187a668251a9ec">https://github.com/ceph/ceph/commit/2a23eac54957e596d99985bb9e187a668251a9ec</a> . The commit log says "move argparse to ceph-common", but that's not what the commit does - it moves it to the main "ceph" package instead.</p>
Given that we desire the following:
<ol>
<li><code>/usr/bin/ceph</code> should remain in ceph-common</li>
<li><code>/usr/bin/ceph</code>'s dependencies should be fully-satisfied by the packaging metadata (it should not crash)</li>
<li>The Debian and Red Hat packaging file lists should be aligned, and the Red Hat packaging <strong>does</strong> ship <code>ceph_argparse.py</code> in the ceph-common RPM.</li>
</ol>
<p>... the solution here is to move ceph_argparse.py out of the "ceph" deb and into the "ceph-common" deb.</p> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=506012015-04-14T14:24:01ZYuri Weinsteinyweinste@redhat.com
<ul><li><strong>Project</strong> changed from <i>Stable releases</i> to <i>devops</i></li><li><strong>Affected Versions</strong> deleted (<del><i></i></del>)</li></ul> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=506032015-04-14T14:30:55ZKen Dreyerkdreyer@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p>Branch for master: <a class="external" href="https://github.com/ceph/ceph/tree/wip-11388-debian-argparse">https://github.com/ceph/ceph/tree/wip-11388-debian-argparse</a><br />Branch for hammer: <a class="external" href="https://github.com/ceph/ceph/tree/wip-11388-hammer-debian-argparse">https://github.com/ceph/ceph/tree/wip-11388-hammer-debian-argparse</a></p> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=506042015-04-14T14:31:10ZKen Dreyerkdreyer@redhat.com
<ul><li><strong>Assignee</strong> set to <i>Ken Dreyer</i></li></ul> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=506062015-04-14T15:12:15ZKen Dreyerkdreyer@redhat.com
<ul></ul><p>Jens, our "gitbuilder" CI system has built the branches in Git that I've posted above. Can you test the ceph-common package here? (Ideally you'd uninstall "ceph" to be sure this is working as you'd expect.)</p>
<p><a class="external" href="http://gitbuilder.ceph.com/ceph-deb-precise-x86_64-basic/ref/wip-11388-hammer-debian-argparse/">http://gitbuilder.ceph.com/ceph-deb-precise-x86_64-basic/ref/wip-11388-hammer-debian-argparse/</a></p>
<p>There are general instructions for testing gitbuilder packages, here: <a class="external" href="http://ceph.com/docs/master/install/get-packages/#add-ceph-development">http://ceph.com/docs/master/install/get-packages/#add-ceph-development</a></p>
<p>As you can see in the URL above, the branch name with my fix is "wip-11388-hammer-debian-argparse"</p> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=506092015-04-14T15:55:23ZJens Harbottj.harbott@x-ion.de
<ul></ul><p>Tested the new package and it works fine.</p>
<p>Thanks for the fast solution.</p> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=506222015-04-14T16:17:24ZJens Harbottj.harbott@x-ion.de
<ul></ul><p>Minor nit about the commit message: The library is called ceph_argparse, there is a different global python library called argparse, so maybe you can be more explicit there to avoid confusion.</p> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=506242015-04-14T16:30:15ZKen Dreyerkdreyer@redhat.com
<ul></ul><p>That's a great catch, thanks Jens.</p>
<p>I've amended the commit message and re-pushed to the branch for master: <a class="external" href="https://github.com/ceph/ceph/tree/wip-11388-debian-argparse">https://github.com/ceph/ceph/tree/wip-11388-debian-argparse</a></p>
<p>Since this touches the debian files as well, this PR might conflict with the one currently under review, at <a class="external" href="https://github.com/ceph/ceph/pull/4353">https://github.com/ceph/ceph/pull/4353</a> . As soon as that one is merged, I'll submit this one.</p> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=522212015-05-20T22:01:28ZKen Dreyerkdreyer@redhat.com
<ul><li><strong>Tracker</strong> changed from <i>Tasks</i> to <i>Bug</i></li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Pending Backport</i></li><li><strong>Regression</strong> set to <i>No</i></li></ul> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=534872015-06-12T19:26:18ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Backport</strong> set to <i>hammer</i></li></ul> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=542142015-06-29T07:27:40ZJens Harbottj.harbott@x-ion.de
<ul></ul><p>Any chance to get this fix backported into hammer soon? Turns out that 0.94.2 is still broken.</p> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=542452015-06-29T23:31:18ZKen Dreyerkdreyer@redhat.com
<ul></ul><p>( For the record, the PR where this was merged to master is <a class="external" href="https://github.com/ceph/ceph/pull/4517">https://github.com/ceph/ceph/pull/4517</a> )</p> devops - Bug #11388: /usr/bin/ceph from ceph-common is broken without installing cephhttps://tracker.ceph.com/issues/11388?journal_id=558402015-07-29T07:05:30ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Status</strong> changed from <i>Pending Backport</i> to <i>Resolved</i></li></ul>