Bug #11381: messenger: double clear of pipe in reaper - Messengers - Ceph

Actions

Copy link

Bug #11381

closed

messenger: double clear of pipe in reaper

Added by Greg Farnum about 9 years ago. Updated about 5 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Haomai Wang

Category:

Target version:

% Done:

Source:

Q/A

Tags:

Backport:

hammer

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

http://qa-proxy.ceph.com/teuthology/teuthology-2015-04-12_23:08:01-kcephfs-hammer-testing-basic-multi/845901/

2015-04-13 06:04:05.049191 7fa3f518a700 -1 msg/simple/SimpleMessenger.cc: In function 'void SimpleMessenger::reaper()' thread 7fa3f518a700 time 2015-04-13 06:04:05.047092
msg/simple/SimpleMessenger.cc: 237: FAILED assert(!cleared)

 ceph version 0.94-5-g7338647 (733864738fa93979727e480e403293e079bb51e9)
 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x7f) [0xaebf4f]
 2: (SimpleMessenger::reaper()+0x9b1) [0xac5381]
 3: (SimpleMessenger::reaper_entry()+0x134) [0xac6554]
 4: (SimpleMessenger::ReaperThread::entry()+0xd) [0xaccc2d]
 5: (()+0x7e9a) [0x7fa3fa556e9a]
 6: (clone()+0x6d) [0x7fa3f8cff3fd]
 NOTE: a copy of the executable, or `objdump -rdS <executable>` is needed to interpret this.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Haomai Wang about 9 years ago

Hi Greg, I'm not sure whether you have solved this problem. I just remember that in Pipe::fault we have potential probability to cause this.

In pipe.cc:1353 we stop this connection and we will let reader and write threads stop. If now reader and writer quit ASAP and we call queue_reap to trigger the reap progress. Now we haven't call "connection_state->clear_pipe(this)" in pipe.cc:1379, so we may assert cleared here.

Is it true?

Actions

Copy link