Bug #11256
rgw: object set attrs clobbers object removal bucket index update
0%
Description
- fix in master commit:4e6a66b and commit:edc0627
Associated revisions
rgw: generate new tag for object when setting object attrs
Fixes: #11256
Backport: firefly, hammer
Beforehand we were reusing the object's tag, which is problematic as
this tag is used for bucket index updates, and we might be clobbering a
racing update (like object removal).
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
cls_rgw: use multimap to keep pending operations in bucket index
Fixes: #11256
Multiple concurrent requests might be sent using the same tag, need the
entry map to be able to hold multiple entries.
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
rgw: generate new tag for object when setting object attrs
Fixes: #11256
Backport: firefly, hammer
Beforehand we were reusing the object's tag, which is problematic as
this tag is used for bucket index updates, and we might be clobbering a
racing update (like object removal).
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
cls_rgw: use multimap to keep pending operations in bucket index
Fixes: #11256
Multiple concurrent requests might be sent using the same tag, need the
entry map to be able to hold multiple entries.
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
rgw: generate new tag for object when setting object attrs
Fixes: #11256
Backport: firefly, hammer
Beforehand we were reusing the object's tag, which is problematic as
this tag is used for bucket index updates, and we might be clobbering a
racing update (like object removal).
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit edc0627a1dbeb66ea2f5f177f6ceca64559ff3d8)
cls_rgw: use multimap to keep pending operations in bucket index
Fixes: #11256
Multiple concurrent requests might be sent using the same tag, need the
entry map to be able to hold multiple entries.
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit 4e6a66b55e73c01347fc3330faa5c1307d29e9d3)
History
#1 Updated by Ian Colle over 8 years ago
- Status changed from New to 7
#2 Updated by Yehuda Sadeh over 8 years ago
- Status changed from 7 to Fix Under Review
- Assignee changed from Yehuda Sadeh to Josh Durgin
- Backport changed from firefly to firefly, hammer
#3 Updated by Yehuda Sadeh over 8 years ago
- Status changed from Fix Under Review to Pending Backport
- hammer backport commit:7c7e651 and commit:cb75713
#4 Updated by Loïc Dachary over 8 years ago
- Description updated (diff)
- Regression set to No
#5 Updated by Loïc Dachary over 8 years ago
- Description updated (diff)
#6 Updated by Nathan Cutler over 8 years ago
- firefly backport: https://github.com/ceph/ceph/pull/4571
#7 Updated by Nathan Cutler over 8 years ago
both hammer and firefly backports appear to have been merged - does that mean this issue can be closed?
#8 Updated by Loïc Dachary over 8 years ago
- Status changed from Pending Backport to Resolved