Project

General

Profile

Actions
Copy link

Bug #11231

closed

perf counter for bool parameter

Added by Xinze Chi about 9 years ago. Updated about 8 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

input:
ceph tell osd.0 injectargs "--osd_enable_op_tracker true"

Output:
failed to parse arguments: true
osd_enable_op_tracker = 'true'

Is my command wrong? or it is a bug? If it is a bug, I would fix it.

Actions
Copy link
 #1

Updated by Sage Weil almost 9 years ago

  • Status changed from New to Rejected

for a bool option, you can do

--foo
 --no-foo
 --foo=(0|false|no)
 --foo=(1|true|yes)
Actions
Copy link
 #2

Updated by Jevon Qiao about 8 years ago

Sage Weil wrote:

for a bool option, you can do

--foo
--no-foo
--foo=(0|false|no)
--foo=(1|true|yes)

It seems all above options do not work for me:
$ ceph tell osd.144 injectargs "--osd_enable_op_tracker no"
failed to parse arguments: no
osd_enable_op_tracker = 'true'

$ ceph tell osd.144 injectargs "--osd_enable_op_tracker 0"
failed to parse arguments: 0
osd_enable_op_tracker = 'true'

$ ceph tell osd.144 injectargs "--osd_enable_op_tracker false"
failed to parse arguments: false
osd_enable_op_tracker = 'true'

BTW, my ceph version is 0.80.91.

Actions
Copy link
 #3

Updated by Jevon Qiao about 8 years ago

$ ceph tell osd.144 injectargs "--osd_enable_op_tracker=false"
Invalid command: saw 0 of injected_args(<string>) [<string>...], expected at least 1
injectargs <injected_args> [<injected_args>...] : inject configuration arguments into running OSD
Error EINVAL: invalid command

$ ceph tell osd.144 injectargs "--osd_enable_op_tracker=no"
Invalid command: saw 0 of injected_args(<string>) [<string>...], expected at least 1
injectargs <injected_args> [<injected_args>...] : inject configuration arguments into running OSD
Error EINVAL: invalid command

$ ceph tell osd.144 injectargs "--osd_enable_op_tracker=0"
Invalid command: saw 0 of injected_args(<string>) [<string>...], expected at least 1
injectargs <injected_args> [<injected_args>...] : inject configuration arguments into running OSD
Error EINVAL: invalid command

These do not work either.

Actions
Copy link

Also available in: Atom PDF