Bug #11180: rgwadmin tasks assumes non-regional output - rgw - Ceph

Bug #11180

rgwadmin tasks assumes non-regional output

Added by Alfredo Deza over 8 years ago. Updated over 8 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Alfredo Deza

Target version:

% Done:

Source:

other

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

It picks the first item in the summary list, which has nothing to do with the user that should be used:

Traceback (most recent call last):
  File "/home/adeza/teuthology/teuthology/run_tasks.py", line 53, in run_tasks
    manager = run_one_task(taskname, ctx=ctx, config=config)
  File "/home/adeza/teuthology/teuthology/run_tasks.py", line 41, in run_one_task
    return fn(**kwargs)
  File "./ceph-qa-suite/tasks/radosgw_admin.py", line 835, in task
    assert total['successful_ops'] > 0, 'Total: %s' % total
AssertionError: Total: {u'successful_ops': 0, u'bytes_received': 0, u'bytes_sent': 78, u'ops': 1}

Associated revisions

Revision 97e6d808 (diff)
Added by Loic Dachary over 8 years ago

ensure summary is looked for the user we need (part 2)

Move the get_user_summary(out, user) logic to util.rgw so that it can be
shared between radosgw_admin_rest.py and radosgw_admin.py and modify
them accordingly.

http://tracker.ceph.com/issues/11180 Fixes: #11180

Signed-off-by: Loic Dachary <loic@dachary.org>

Revision fc395509 (diff)
Added by Loic Dachary over 8 years ago

ensure summary is looked for the user we need (part 2)

Move the get_user_summary(out, user) logic to util.rgw so that it can be
shared between radosgw_admin_rest.py and radosgw_admin.py and modify
them accordingly.

http://tracker.ceph.com/issues/11180 Fixes: #11180

Signed-off-by: Loic Dachary <loic@dachary.org>
(cherry picked from commit 97e6d808f086834f2350084d5de36be285ad2bde)

Revision 4cc8e401 (diff)
Added by Loic Dachary over 8 years ago

ensure summary is looked for the user we need (part 2)

Move the get_user_summary(out, user) logic to util.rgw so that it can be
shared between radosgw_admin_rest.py and radosgw_admin.py and modify
them accordingly.

http://tracker.ceph.com/issues/11180 Fixes: #11180

Signed-off-by: Loic Dachary <loic@dachary.org>
(cherry picked from commit 97e6d808f086834f2350084d5de36be285ad2bde)

Conflicts:
tasks/radosgw_admin.py
the context around def successful_ops(out): changed but is
unrelated to the modification

History

#1 Updated by Alfredo Deza over 8 years ago

Status changed from New to Fix Under Review

Pull request opened: https://github.com/ceph/ceph-qa-suite/pull/372

#2 Updated by Alfredo Deza over 8 years ago

Status changed from Fix Under Review to Resolved

merged commit dfea7dd into master
And cherry-picked the commit onto firefly, hammer, giant, dumpling, and next

#3 Updated by Loïc Dachary over 8 years ago

The problem manifests itself in other places as well. The real question is : why does it show up now ? How did it work a month ago ? Nothing significant seems to have changed. http://pulpito.ceph.com/loic-2015-03-22_10:53:10-rgw-giant-backports---basic-multi/ . It could be just random luck (i.e. the non regional summary was always inserted first) but...

#4 Updated by Loïc Dachary over 8 years ago

Status changed from Resolved to 12

The following seem to have the same problem

which would explain why http://pulpito.ceph.com/loic-2015-03-22_14:55:18-rgw-v0.87.1---basic-multi/815825/ fails

#5 Updated by Yehuda Sadeh over 8 years ago

My guess is that it's the new versioning detection code in the radosgw sync agent. We probably set it up, but don't use it until later. Originally, it was only generating requests during the s3-tests run, but now it sends one request on startup.

#6 Updated by Abhishek Lekshmanan over 8 years ago

Isn't summary supposed to be a total view of other usage elements? ie. if successful ops are greater than zero isn't summary[successful_ops] supposed to be > 0 for eg. Or am I missing something else here?

#7 Updated by Loïc Dachary over 8 years ago

Status changed from 12 to Fix Under Review

https://github.com/ceph/ceph-qa-suite/pull/375

#8 Updated by Loïc Dachary over 8 years ago

testing a giant cherry-pick with

filter='rgw/singleton/{all/radosgw-admin-data-sync.yaml frontend/civetweb.yaml rgw_pool_type/ec.yaml},rgw/singleton/{all/radosgw-admin-data-sync.yaml frontend/civetweb.yaml rgw_pool_type/ec-cache.yaml},rgw/singleton/{all/radosgw-admin-data-sync.yaml frontend/apache.yaml rgw_pool_type/ec.yaml},rgw/singleton/{all/radosgw-admin-data-sync.yaml frontend/apache.yaml rgw_pool_type/ec-cache.yaml},rgw/multifs/{clusters/fixed-2.yaml frontend/civetweb.yaml fs/xfs.yaml rgw_pool_type/replicated.yaml tasks/rgw_s3tests.yaml},rgw/multifs/{clusters/fixed-2.yaml frontend/civetweb.yaml fs/xfs.yaml rgw_pool_type/ec.yaml tasks/rgw_s3tests.yaml},rgw/multifs/{clusters/fixed-2.yaml frontend/civetweb.yaml fs/xfs.yaml rgw_pool_type/ec-profile.yaml tasks/rgw_s3tests.yaml},rgw/multifs/{clusters/fixed-2.yaml frontend/civetweb.yaml fs/xfs.yaml rgw_pool_type/ec-cache.yaml tasks/rgw_s3tests.yaml},rgw/multifs/{clusters/fixed-2.yaml frontend/apache.yaml fs/xfs.yaml rgw_pool_type/replicated.yaml tasks/rgw_s3tests.yaml},rgw/multifs/{clusters/fixed-2.yaml frontend/apache.yaml fs/xfs.yaml rgw_pool_type/ec.yaml tasks/rgw_s3tests.yaml},rgw/multifs/{clusters/fixed-2.yaml frontend/apache.yaml fs/xfs.yaml rgw_pool_type/ec-profile.yaml tasks/rgw_s3tests.yaml},rgw/multifs/{clusters/fixed-2.yaml frontend/apache.yaml fs/xfs.yaml rgw_pool_type/ec-cache.yaml tasks/rgw_s3tests.yaml}'
./virtualenv/bin/teuthology-suite --filter="$filter" --priority 101 --suite rgw --filter-out btrfs,ext4 --suite-branch wip-rgw-regional-summary --machine-type plana,burnupi,mira --distro ubuntu --email loic@dachary.org --owner loic@dachary.org --ceph giant

http://pulpito.ceph.com/loic-2015-03-23_00:22:33-rgw-giant---basic-multi/