Bug #11065: implement tox tests for ceph-disk - Ceph - Ceph

Actions

Copy link

Bug #11065

closed

implement tox tests for ceph-disk

Added by Loïc Dachary about 9 years ago. Updated about 9 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Alfredo Deza

Category:

Target version:

% Done:

Source:

other

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

to verify python2 / python3 syntax
minimal unittesting

The suggestion for minimal unit testing is because src/test/ceph-disk.sh has integration tests. Since ceph-disk desired side effects require an integration environment for the most part, actual unit testing would require a lot of mocking which is both prone to error and tedious to maintain.

Actions

Copy link

Updated by Alfredo Deza about 9 years ago

Assignee set to Alfredo Deza

Actions

Copy link

Updated by Alfredo Deza about 9 years ago

Enforcing unit tests for new helpers and small functions will actually make it less error prone, ensure reliable changes and will not require mocking of any sort.

I will get the initial structure with a few tests so that we can get started and start enforcing tests with new changes.

Actions

Copy link