Bug #11048
Session::completed_requests not reliably persisted
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Creating a separate ticket to distinguish this from the #10649 code.
This was a pre-existing issue, but it's going to be more noticeable with the OMAP code: there was nothing to save the sessionmap as a result of updates to completed_requests (either add_completed_request or trim_completed_requests) calls.
The example of where this matters (from zheng) is:
I think we need to save completed_requests for corner cases. consider following scenario: Client A sends setattr request to MDS MDS handles the request and sends reply to client. But network between MDS and client A becomes disconnected. MDS handles lots of setattr requests from other clients. Log entry for the first setattr request get trimmed MDS crashed, standby MDS on other host takes over. Client A re-send the setattr request to the new MDS.
Associated revisions
mds: persist completed_requests reliably
Ensure that if this was modified during
a segment, and the session is not
persisted for some other reason, we
go ahead and persist it at the end
of the segment.
Fixes: #11048
Signed-off-by: John Spray <john.spray@redhat.com>
History
#1 Updated by John Spray about 9 years ago
- Status changed from New to In Progress
- Assignee set to John Spray
#2 Updated by John Spray almost 9 years ago
- Status changed from In Progress to Fix Under Review
#3 Updated by Greg Farnum almost 9 years ago
- Status changed from Fix Under Review to Resolved
Merged to master in commit:0b94bf547d0c452a3d5758ea4f4791566eab5c82