Bug #11026
objecter: can get stuck in redirect loop if osdmap epoch == last_force_op_resend
0%
Description
if (osdmap->get_epoch() == pi->last_force_op_resend) {
force_resend = true;
}
in Objecter.cc will stay true if the osdmap doesn't roll over again after an operation that sets last_force_op_resend (like a cache mode change).
see https://github.com/majianpeng/ceph/commit/2f0518d6da9d7f9d9fd109c0848eb422ad05264d comments for a discussion
Related issues
Associated revisions
osdc: add epoch_t last_force_resend in Op/LingerOp.
Using this field record the pg_poo_t::last_force_op_resend to avoid op
endless when osd reply with redirect.
Fixes: #11026
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: Sage Weil <sage@redhat.com>
osdc: add epoch_t last_force_resend in Op/LingerOp.
Using this field record the pg_poo_t::last_force_op_resend to avoid op
endless when osd reply with redirect.
Fixes: #11026
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit def4fc4ae51174ae92ac1fb606427f4f6f00743e)
osdc: add epoch_t last_force_resend in Op/LingerOp.
Using this field record the pg_poo_t::last_force_op_resend to avoid op
endless when osd reply with redirect.
Fixes: #11026
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit def4fc4a)
History
#1 Updated by jianpeng ma almost 5 years ago
jianpeng send a pull request(https://github.com/ceph/ceph/pull/3870) which can fix this bug.
#2 Updated by Sage Weil over 4 years ago
- Status changed from New to 7
#3 Updated by Loic Dachary over 4 years ago
- Backport changed from hammer, giant, firefly to hammer, firefly
giant is end of life
#4 Updated by Kefu Chai over 4 years ago
- Status changed from 7 to Pending Backport
#5 Updated by Loic Dachary over 4 years ago
- Severity changed from 3 - minor to 2 - major
#6 Updated by Loic Dachary over 4 years ago
- hammer backport https://github.com/ceph/ceph/pull/4502
#7 Updated by Loic Dachary over 4 years ago
- Regression set to No
today xinxinsh tried a backport to firefly but had issues and asked for feedback to Jianpeng Ma
#8 Updated by Xinxin Shu over 4 years ago
- firefly backport https://github.com/ceph/ceph/pull/4597
#9 Updated by Nathan Cutler over 4 years ago
- Status changed from Pending Backport to Resolved