Project

General

Profile

Bug #11026

objecter: can get stuck in redirect loop if osdmap epoch == last_force_op_resend

Added by Sage Weil about 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
hammer, firefly
Regression:
No
Severity:
2 - major
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

if (osdmap->get_epoch() == pi->last_force_op_resend) {
force_resend = true;
}

in Objecter.cc will stay true if the osdmap doesn't roll over again after an operation that sets last_force_op_resend (like a cache mode change).

see https://github.com/majianpeng/ceph/commit/2f0518d6da9d7f9d9fd109c0848eb422ad05264d comments for a discussion

Related issues

Copied to Ceph - Backport #11702: objecter: can get stuck in redirect loop if osdmap epoch == last_force_op_resend Resolved 03/05/2015
Copied to Ceph - Backport #11703: objecter: can get stuck in redirect loop if osdmap epoch == last_force_op_resend Resolved 03/05/2015

Associated revisions

Revision def4fc4a (diff)
Added by Jianpeng Ma about 6 years ago

osdc: add epoch_t last_force_resend in Op/LingerOp.

Using this field record the pg_poo_t::last_force_op_resend to avoid op
endless when osd reply with redirect.

Fixes: #11026
Signed-off-by: Jianpeng Ma <>
Signed-off-by: Sage Weil <>

Revision 8d9f4d4e (diff)
Added by Jianpeng Ma about 6 years ago

osdc: add epoch_t last_force_resend in Op/LingerOp.

Using this field record the pg_poo_t::last_force_op_resend to avoid op
endless when osd reply with redirect.

Fixes: #11026
Signed-off-by: Jianpeng Ma <>
Signed-off-by: Sage Weil <>
(cherry picked from commit def4fc4ae51174ae92ac1fb606427f4f6f00743e)

Revision b1ff7396 (diff)
Added by xinxin shu almost 6 years ago

osdc: add epoch_t last_force_resend in Op/LingerOp.

Using this field record the pg_poo_t::last_force_op_resend to avoid op
endless when osd reply with redirect.

Fixes: #11026
Signed-off-by: Jianpeng Ma <>
Signed-off-by: Sage Weil <>
(cherry picked from commit def4fc4a)

History

#1 Updated by jianpeng ma about 6 years ago

jianpeng send a pull request(https://github.com/ceph/ceph/pull/3870) which can fix this bug.

#2 Updated by Sage Weil about 6 years ago

  • Status changed from New to 7

#3 Updated by Loïc Dachary about 6 years ago

  • Backport changed from hammer, giant, firefly to hammer, firefly

giant is end of life

#4 Updated by Kefu Chai about 6 years ago

  • Status changed from 7 to Pending Backport

#5 Updated by Loïc Dachary about 6 years ago

  • Severity changed from 3 - minor to 2 - major

#7 Updated by Loïc Dachary almost 6 years ago

  • Regression set to No

today xinxinsh tried a backport to firefly but had issues and asked for feedback to Jianpeng Ma

#9 Updated by Nathan Cutler almost 6 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF