Project

General

Profile

Actions

Feature #10976

closed

fix PG::all_unfound_are_queried_or_lost for non-existent osds

Added by Samuel Just about 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
firefly
Reviewed:
Affected Versions:
Pull request ID:

Description

A common mistake upon osd loss is to remove the osd from the crush map before marking the osd lost. This tends to make it so that the user can no longer mark the osd lost to satisfy all_unfound_are_queried_or_lost. The simple solution is probably for all_unfound_are_queried_or_lost to ignore the osd if it does not exist. As a side note, the get_info usage there isn't quite valid since the osd might not still exist -- it needs to be guarded by an exists() check anyway.

This ticket includes extending the mark_lost_unfound_lost test to include this case.

Actions #1

Updated by Samuel Just about 9 years ago

  • Target version set to v0.94
Actions #2

Updated by Samuel Just about 9 years ago

  • Target version deleted (v0.94)
Actions #3

Updated by Samuel Just about 9 years ago

  • Subject changed from PG::all_unfound_are_queried_or_lost to fix PG::all_unfound_are_queried_or_lost for non-existent osds
Actions #4

Updated by Samuel Just about 9 years ago

  • Description updated (diff)
Actions #5

Updated by Kefu Chai about 9 years ago

  • Status changed from New to Fix Under Review
Actions #6

Updated by Samuel Just about 9 years ago

  • Backport set to giant, firefly
Actions #7

Updated by Samuel Just about 9 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #8

Updated by Loïc Dachary almost 9 years ago

  • Backport changed from giant, firefly to firefly

giant is end of life

Actions #9

Updated by Loïc Dachary almost 9 years ago

  • Status changed from Pending Backport to Resolved
  • Backport deleted (firefly)

we are no longer backporting features / improvements to firefly, only bug fixes

Actions #10

Updated by Loïc Dachary almost 9 years ago

  • Backport set to firefly
Actions

Also available in: Atom PDF