Project

General

Profile

Actions
Copy link

Feature #10910

closed

Allow Remote.get_file() to use original filename locally

Added by Zack Cerza about 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Zack Cerza
Category:
-
Target version:
sprint24
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:

Description

Currently Remote.get_file() calls tempfile.mkstemp() to generate a local filename. I think it should allow using the original filename.

I think it is sane enough to call mkstemp() if the default dest_dir value of /tmp is used, but use the original filename for non-/tmp values of dest_dir.

I haven't found any current callers that will be affected by this.

This was inspired by:
https://github.com/ceph/teuthology/pull/424/files#r24864746

Actions
Copy link
 #1

Updated by Zack Cerza about 9 years ago

  • Status changed from In Progress to Fix Under Review
  • Target version set to sprint24
Actions
Copy link

Also available in: Atom PDF