Project

General

Profile

Bug #10835

SAMBA VFS module: free/total disk space return values

Added by Dennis Kramer over 4 years ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
02/11/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Samba/CIFS
Pull request ID:

Description

The return values for free/total disk space is not working correctly when you mount a share in Windows. My 340TB cluster had 7.3EB storage available in Windows which obviously is incorrect. I'm using a workaround by using a custom "dfree command =" script in the smb.conf, but VFS will override this and thus this script will not work (unless you remove the lines of codes for these specific disk operations in vfs_ceph.c).

I've compiled samba from samba-latest source (4.1.16) on Ubuntu 14.04LTS
My CEPH cluster is running version 0.87 (c51c8f9d80fa4e0168aa52685b8de40e42758578) on Ubuntu 14.04LTS

patch View (699 Bytes) Zheng Yan, 02/13/2015 09:52 AM

History

#1 Updated by Zheng Yan over 4 years ago

remove which line of code of vfs_ceph.c can fix the issue?

#2 Updated by Dennis Kramer over 4 years ago

It's not a fix, its a workaround to get the smb.conf parameter "dfree command" working. It seems like if the ".disk_free_fn = cephwrap_disk_free" (which doesn't give the correct return values) is defined in vfs_ceph.c it will override the parameter "dfree command" in smb.conf if set.

#3 Updated by Zheng Yan over 4 years ago

  • File patch View added
  • Status changed from New to Testing

could you try the attached patch

#4 Updated by Dennis Kramer over 4 years ago

Awesome! It works.
Thank you.

#5 Updated by Zheng Yan over 4 years ago

  • Status changed from Testing to Resolved

upstreamed by commit 2501afe08b94a514d8e2f3eeb4a2c4edc9764979

#6 Updated by Patrick Donnelly 6 months ago

  • Category deleted (43)
  • Labels (FS) Samba/CIFS added

Also available in: Atom PDF