Project

General

Profile

Actions

Bug #10503

closed

ceph-fuse: quota code is not 32-bit safe for vxattr output

Added by Greg Farnum over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

From the gitbuilders:

client/Client.cc: In member function 'size_t Client::_vxattrcb_quota(Inode*, char*, size_t)':
warning: client/Client.cc:8575:38: format '%ld' expects argument of type 'long int', but argument 4 has type 'int64_t {aka long long int}' [-Wformat=]
in->quota.max_files);
^
warning: client/Client.cc:8575:38: format '%ld' expects argument of type 'long int', but argument 5 has type 'int64_t {aka long long int}' [-Wformat=]
warning: client/Client.cc:8575:38: format '%ld' expects argument of type 'long int', but argument 4 has type 'int64_t {aka long long int}' [-Wformat=]
warning: client/Client.cc:8575:38: format '%ld' expects argument of type 'long int', but argument 5 has type 'int64_t {aka long long int}' [-Wformat=]
client/Client.cc: In member function 'size_t Client::_vxattrcb_quota_max_bytes(Inode*, char*, size_t)':
warning: client/Client.cc:8579:56: format '%ld' expects argument of type 'long int', but argument 4 has type 'int64_t {aka long long int}' [-Wformat=]
return snprintf(val, size, "%ld", in->quota.max_bytes);
^
warning: client/Client.cc:8579:56: format '%ld' expects argument of type 'long int', but argument 4 has type 'int64_t {aka long long int}' [-Wformat=]
client/Client.cc: In member function 'size_t Client::_vxattrcb_quota_max_files(Inode*, char*, size_t)':
warning: client/Client.cc:8583:56: format '%ld' expects argument of type 'long int', but argument 4 has type 'int64_t {aka long long int}' [-Wformat=]
return snprintf(val, size, "%ld", in->quota.max_files);
^
warning: client/Client.cc:8583:56: format '%ld' expects argument of type 'long int', but argument 4 has type 'int64_t {aka long long int}' [-Wformat=]
Actions #1

Updated by Greg Farnum over 9 years ago

  • Status changed from New to Resolved

Fix merged to master in commit:c219c43cc2943c794378214d77566e3f0d3f394a

Actions

Also available in: Atom PDF