Project

General

Profile

Actions
Copy link

Bug #10296

closed

OSD crashes if device name does not start with sd

Added by Loïc Dachary over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Sage Weil
Category:
-
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

http://workbench.dachary.org/ceph/ceph/blob/master/src/common/blkdev.cc#L31 will set p to NULL if sd does not show in the device name and http://workbench.dachary.org/ceph/ceph/blob/master/src/common/blkdev.cc#L34 will try to read a null pointer.

Actions
Copy link
 #2

Updated by Sage Weil over 9 years ago

  • Priority changed from Normal to Urgent
  • Source changed from other to Q/A

argh, i caught this in review but then forgot about it before merge. i think it needs to do all manner of weirdness like ceph-disk does to find the base device

Actions
Copy link
 #3

Updated by Sage Weil over 9 years ago

  • Assignee changed from Loïc Dachary to Sage Weil
Actions
Copy link
 #4

Updated by Loïc Dachary over 9 years ago

workaround https://github.com/ceph/ceph/pull/3152 that bypasses the problem until a proper fix is committed

Actions
Copy link
 #5

Updated by Sage Weil over 9 years ago

  • Status changed from 12 to Fix Under Review
Actions
Copy link
 #6

Updated by Sage Weil over 9 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link

Also available in: Atom PDF