Bug #10279
closed--os-version and --os-type is not respected
0%
Description
When running teuthology the --os-version and --os-type flags aren't respected. If present, they are ignored and the values from the yaml config is still used.
Updated by Andrew Schoen over 9 years ago
Updated by Andrew Schoen over 9 years ago
- Status changed from Resolved to In Progress
This patch for this was reverted after discovering a bug related to the default value of --os-type. From what I can gather that default value could safely be removed. The default seems to be set in teuthology.misc.get_distro.
It'll be difficult to use --os-type as an override for config values when it's always defaulted to 'ubuntu'. How would we know when it's actually being used and when it's just the default?
Updated by Zack Cerza over 9 years ago
As I recall it, the breakage was caused in a run whose job config contained:
os_type: rhel os_version: '7.0'
Since the job was scheduled, teuthology was called without --os-type or --os-version. Since scripts/run.py contains a default for --os-type ('ubuntu') and not for --os-version, the job ended up trying to provision a vps with os_type: ubuntu and os_version: '7.0', which is impossible.
It does seem that removing the --os-type default from scripts/run.py and making teutholog.run.main() respect the values properly would work well. We'd also probably want to move get_distro() and get_distro_version() from teuthology.misc to teuthology.provision, since that module is the only user of those functions.
Updated by Andrew Schoen over 9 years ago
Updated by Andrew Schoen over 9 years ago
- Status changed from In Progress to Resolved