Project

General

Profile

Fix #10256

recode get-flavor.sh/Makefile to be cleaner about version identification/adaptation

Added by Dan Mick over 9 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Backend (packaging/deployment)
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

Once, get-flavor.sh/FLAVOR were used to select Apache config styles, Python minor version numbers, and calamari.conf settings; the first two of those have been replaced by direct mechanisms not tied to distro/version, and the latter is fairly simple usage except for suse (rhel7 and el6 are the same, and debian only differs in apache user name).

We should have a more generic/flexible mechanism for these sorts of configuration things, ideally not even tied directly to distro; for the apache user, for instance, it would be nice if there were a way to sense that user by testing the build system. The extra suse differences have mostly to do with "base installation path" differences, and could be addressed better, probably, by making those paths relative, and also by transitioning to a more-standard installation layout, which is overdue anyway.

History

#1 Updated by Dan Mick over 9 years ago

  • Tracker changed from Feature to Fix
  • Project changed from Ceph to Calamari

#2 Updated by Dan Mick over 9 years ago

  • Category set to Backend (packaging/deployment)
  • Source changed from other to Community (dev)

This addresses issues raised in both https://github.com/ceph/calamari/pull/221 and https://github.com/ceph/calamari/pull/229. I'd really rather not continue the get-flavor.sh hack (which was all mine, and expedient until I understood better what we needed to parameterize).

#3 Updated by Patrick Donnelly over 4 years ago

  • Status changed from 12 to New

#4 Updated by Dan Mick almost 4 years ago

  • Status changed from New to Closed

Also available in: Atom PDF