Project

General

Profile

Fix #10135

OSDMonitor: allow adding cache pools to cephfs pools already in use

Added by Greg Farnum almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
11/18/2014
Due date:
% Done:

0%

Source:
Community (user)
Tags:
Backport:
giant
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:

Description

Right now we disallow this with _check_remove_tier(), I believe because we were worried about coordinating the switchover. The OSDs and rados clients handle this though, thanks to their force_resend_op stuff.

Associated revisions

Revision 17b5fc9a (diff)
Added by John Spray over 4 years ago

mon: OSDMonitor: allow adding tiers to FS pools

This was an overly-strict check. In fact it is perfectly
fine to set an overlay on a pool that is already in use
as a filesystem data or metadata pool.

Fixes: #10135

Signed-off-by: John Spray <>

Revision 7cd8c3f8 (diff)
Added by John Spray over 4 years ago

mon: OSDMonitor: allow adding tiers to FS pools

This was an overly-strict check. In fact it is perfectly
fine to set an overlay on a pool that is already in use
as a filesystem data or metadata pool.

Fixes: #10135

Signed-off-by: John Spray <>
(cherry picked from commit 17b5fc9a40440e76dd1fa64f7fc19577ae3b58ce)

History

#1 Updated by John Spray almost 5 years ago

Yeah, we didn't think about this first time around because the focus was on cache tiers to EC pools, but it would make sense to allow adding cache tiers to replicated pools in use by cephfs.

#2 Updated by John Spray over 4 years ago

  • Status changed from New to Need Review

#3 Updated by Greg Farnum over 4 years ago

  • Status changed from Need Review to Pending Backport

merged to next in commit:25fc21b837ba74bab2f6bc921c78fb3c43993cf5

This also should go into giant (I think Firefly didn't have the issue, right?).

#4 Updated by John Spray over 4 years ago

  • Status changed from Pending Backport to Need Review

#5 Updated by Greg Farnum over 4 years ago

  • Status changed from Need Review to Resolved

26e8cf174b8e76b4282ce9d9c1af6ff12f5565a9

Also available in: Atom PDF