Project

General

Profile

Bug #10106

rgw acl response should start with <?xml version="1.0" ?>

Added by Jon Kåre Hellan almost 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
High
Assignee:
Yehuda Sadeh
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
giant, firefly
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I encountered some surprising behaviour when playing with radosgw and s3cmd.
You can probably make a convincing case that the fault lies with s3cmd. But other
applications could easily be wrong in the same way.

Anyway, when I perform GET /?acl or GET /ObjectName?acl on AWS S3, the response content starts like this:

<?xml version="1.0" ?>
<AccessControlPolicy xmlns="http://s3.amazonaws.com/doc/2006-03-01/">

With radosgw, the '<?xml' line is missing.

This confuses s3cmd, so that it does not understand the ACL. Any chance that radosgw could start sending
the missing line?

Associated revisions

Revision eb45f861 (diff)
Added by Yehuda Sadeh over 6 years ago

rgw: flush xml header on get acl request

Fixes: #10106
Backport: firefly, giant

dump_start() updates the formatter with the appropriate prefix, however,
we never flushed the formatter.

Signed-off-by: Yehuda Sadeh <>

Revision 34d19e15 (diff)
Added by Yehuda Sadeh over 6 years ago

rgw: flush xml header on get acl request

Fixes: #10106
Backport: firefly, giant

dump_start() updates the formatter with the appropriate prefix, however,
we never flushed the formatter.

Signed-off-by: Yehuda Sadeh <>
(cherry picked from commit eb45f861343162e018968b8c56693a8c6f5b2cab)

Revision 96a5c671 (diff)
Added by Yehuda Sadeh over 6 years ago

rgw: flush xml header on get acl request

Fixes: #10106
Backport: firefly, giant

dump_start() updates the formatter with the appropriate prefix, however,
we never flushed the formatter.

Signed-off-by: Yehuda Sadeh <>
(cherry picked from commit eb45f861343162e018968b8c56693a8c6f5b2cab)

History

#1 Updated by Sage Weil almost 7 years ago

  • Assignee set to Yehuda Sadeh
  • Priority changed from Normal to High
  • Source changed from other to Community (user)

#2 Updated by Yehuda Sadeh almost 7 years ago

  • Assignee deleted (Yehuda Sadeh)
  • Priority changed from High to Normal
  • Source changed from Community (user) to other

Note that Amazon's API definition does not specify this:
http://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectGETacl.html

#3 Updated by Yehuda Sadeh almost 7 years ago

  • Assignee set to Yehuda Sadeh
  • Priority changed from Normal to High
  • Source changed from other to Community (user)

#4 Updated by Yehuda Sadeh over 6 years ago

  • Status changed from New to Fix Under Review
  • Backport set to giant, firefly

#5 Updated by Sage Weil over 6 years ago

  • Status changed from Fix Under Review to Pending Backport

#7 Updated by Loïc Dachary over 6 years ago

  • Description updated (diff)

#9 Updated by Sage Weil over 6 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF